Skip to content

Remove implicit dependency on successful completion of verify-links #18277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 4 commits into from
May 18, 2021
Merged

Remove implicit dependency on successful completion of verify-links #18277

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a139725
move verify-links directly into analyze.yml.
scbedd Apr 24, 2021
71dabd7
ensure that dev_reqs are installed before verify sdist. put verify-li…
scbedd Apr 28, 2021
e73a549
accidentally removed Find Invalid Versions
scbedd Apr 28, 2021
bffe791
remove extraneous tab
scbedd Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
move verify-links directly into analyze.yml.
  • Loading branch information
@scbedd
scbedd committed Apr 24, 2021
commit a1397253ef18bbd41dc39751312b48b78c1267e0
9 changes: 0 additions & 9 deletions eng/pipelines/templates/jobs/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,6 @@ jobs:
vmImage: MMSUbuntu18.04

steps:
- template: /eng/common/pipelines/templates/steps/verify-links.yml
parameters:
${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
Directory: ''
Urls: (eng/common/scripts/get-markdown-files-from-changed-files.ps1)
${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
Directory: sdk/${{ parameters.ServiceDirectory }}
CheckLinkGuidance: $true

- template: ../steps/analyze.yml
parameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
Expand Down
10 changes: 10 additions & 0 deletions eng/pipelines/templates/steps/analyze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ parameters:
steps:
- template: /eng/pipelines/templates/steps/analyze_dependency.yml

- template: /eng/common/pipelines/templates/steps/verify-links.yml
parameters:
${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
Directory: ''
Urls: (eng/common/scripts/get-markdown-files-from-changed-files.ps1)
${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
Directory: sdk/${{ parameters.ServiceDirectory }}
CheckLinkGuidance: $true
Condition: succeededOrFailed()

- template: /eng/common/pipelines/templates/steps/set-test-pipeline-version.yml
parameters:
PackageName: "azure-template"
Expand Down