Skip to content

[Key Vault] Add API version 7.2 for keys #18586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mccoyp merged 5 commits into from
Jun 2, 2021
Merged

[Key Vault] Add API version 7.2 for keys #18586

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2b38fe
Regenerate on 1e2c9f3ec
mccoyp May 7, 2021
589b415
Update default API version
mccoyp May 7, 2021
1a2e80e
Update tests
mccoyp May 7, 2021
436038a
Update changelog/new tests
mccoyp May 27, 2021
580adac
Update admin recordings
mccoyp May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update default API version
  • Loading branch information
@mccoyp
mccoyp committed May 27, 2021
commit 589b4156f16003b347c1e42b28ddcfe720b8f592
2 changes: 1 addition & 1 deletion sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/async_client_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# AsyncTokenCredential is a typing_extensions.Protocol; we don't depend on that package
pass

DEFAULT_VERSION = ApiVersion.V7_2_preview
DEFAULT_VERSION = ApiVersion.V7_2

class AsyncKeyVaultClientBase(object):
def __init__(self, vault_url: str, credential: "AsyncTokenCredential", **kwargs: "Any") -> None:
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ class ApiVersion(str, Enum):
"""Key Vault API versions supported by this package"""

#: this is the default version
V7_2_preview = "7.2-preview"
V7_2 = "7.2"
V7_1 = "7.1"
V7_0 = "7.0"
V2016_10_01 = "2016-10-01"

DEFAULT_VERSION = ApiVersion.V7_2_preview
DEFAULT_VERSION = ApiVersion.V7_2


class KeyVaultClientBase(object):
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/azure-keyvault-keys/tests/_test_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def get_decorator(hsm_only=False, vault_only=False, **kwargs):
def get_test_parameters(hsm_only=False, vault_only=False):
"""generates a list of parameter pairs for test case parameterization, where [x, y] = [api_version, is_hsm]"""
combinations = []
hsm_supported_versions = {ApiVersion.V7_2_preview}
hsm_supported_versions = {ApiVersion.V7_2}
for api_version in ApiVersion:
if not vault_only and api_version in hsm_supported_versions:
combinations.append([api_version, True])
Expand Down