Skip to content

[Tables] test cleanup #18676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seankane-msft merged 15 commits into from
May 17, 2021
Merged

[Tables] test cleanup #18676

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8b7f703
moving helper methods to base class, reducing code
seankane-msft May 12, 2021
90ff84e
more duplicates
seankane-msft May 12, 2021
9dcb3e3
consolidating teardown method, new recordings to keep everything green
seankane-msft May 12, 2021
6a329f0
service properties files
seankane-msft May 12, 2021
f9c3f76
insert and create query table methods
seankane-msft May 12, 2021
63bb909
set up for entity tests
seankane-msft May 12, 2021
acbaf7f
finished all refactor
seankane-msft May 12, 2021
59c33e9
reducing refactored code
seankane-msft May 12, 2021
da85b22
calling all methods _set_up
seankane-msft May 12, 2021
d9282b8
more cleanup and sleeps for cosmos tests
seankane-msft May 12, 2021
4a7b6c6
corrections
seankane-msft May 12, 2021
6c3c746
removing prints
seankane-msft May 12, 2021
9c6498f
undoing all my changes to recording files now
seankane-msft May 12, 2021
baeb4d3
adding _ to get_table_reference
seankane-msft May 12, 2021
50489a3
removed commented out code
seankane-msft May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
corrections
  • Loading branch information
@seankane-msft
seankane-msft committed May 12, 2021
commit 4a7b6c69ea316a4ed3716174ddd3daecdeb85bb1
3 changes: 2 additions & 1 deletion sdk/tables/azure-data-tables/tests/_shared/asynctestcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ async def _tear_down(self):
if is_live():
async for table in self.ts.list_tables():
await self.ts.delete_table(table.name)
if u"cosmos" in self.ts.endpoint:
if self.ts._cosmos_endpoint:
print("Cosmos endpoint")
self.sleep(SLEEP_DELAY)
self.test_tables = []
await self.ts.close()
Expand Down
3 changes: 2 additions & 1 deletion sdk/tables/azure-data-tables/tests/_shared/testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,8 @@ def _tear_down(self):
if is_live():
self._delete_all_tables(self.ts)
self.test_tables = []
if "cosmos" in self.ts.endpoint:
if self.ts._cosmos_endpoint:
print("Cosmos endpoint")
self.sleep(SLEEP_DELAY)
self.ts.close()

Expand Down
Loading