Skip to content

Deprecated new_name in Undelete #18690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tasherif-msft merged 4 commits into from
Jul 7, 2021
Merged

Deprecated new_name in Undelete #18690

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44d1241
Deprecated new_name in Undelete
tasherif-msft May 13, 2021
e342fd2
added additional TODO comments on soft delete enabled tests
tasherif-msft May 13, 2021
81bb762
removed it from DSC
tasherif-msft May 13, 2021
5713816
removed line
tasherif-msft May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed it from DSC
  • Loading branch information
@tasherif-msft
tasherif-msft committed May 13, 2021
commit 81bb7625f769f6179323eff2f37a55d367792a08
1 change: 1 addition & 0 deletions sdk/storage/azure-storage-blob/azure/storage/blob/_blob_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,7 @@ def undelete_container(self, deleted_container_name, deleted_container_version,
"""
new_name = kwargs.pop('new_name', None)
if new_name:
warnings.simplefilter('always', DeprecationWarning)
warnings.warn("`new_name` is no longer supported.", DeprecationWarning)
container = self.get_container_client(new_name or deleted_container_name)
try:
Expand Down
1 change: 1 addition & 0 deletions sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_service_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,7 @@ async def undelete_container(self, deleted_container_name, deleted_container_ver
"""
new_name = kwargs.pop('new_name', None)
if new_name:
warnings.simplefilter('always', DeprecationWarning)
Copy link
Contributor

@xiafu-msft xiafu-msft May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anna! I think we should let the user to choose how they want to deal with the warning, what do you think? @annatisch

warnings.warn("`new_name` is no longer supported.", DeprecationWarning)
container = self.get_container_client(new_name or deleted_container_name)
try:
Expand Down
3 changes: 0 additions & 3 deletions ...orage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# Licensed under the MIT License. See License.txt in the project root for
# license information.
# --------------------------------------------------------------------------
import warnings
from typing import Optional, Dict, Any

try:
Expand Down Expand Up @@ -300,8 +299,6 @@ def undelete_file_system(self, name, deleted_version, **kwargs):
:rtype: ~azure.storage.filedatalake.FileSystemClient
"""
new_name = kwargs.pop('new_name', None)
if new_name:
warnings.warn("`new_name` is no longer supported.", DeprecationWarning)
file_system = self.get_file_system_client(new_name or name)
self._blob_service_client.undelete_container(
name, deleted_version, new_name=new_name, **kwargs) # pylint: disable=protected-access
Expand Down
3 changes: 0 additions & 3 deletions ...e-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_service_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# license information.
# --------------------------------------------------------------------------
# pylint: disable=invalid-overridden-method
import warnings
from typing import Optional, Any, Dict

from azure.core.paging import ItemPaged
Expand Down Expand Up @@ -250,8 +249,6 @@ async def undelete_file_system(self, name, deleted_version, **kwargs):
:rtype: ~azure.storage.filedatalake.FileSystemClient
"""
new_name = kwargs.pop('new_name', None)
if new_name:
warnings.warn("`new_name` is no longer supported.", DeprecationWarning)
await self._blob_service_client.undelete_container(name, deleted_version, new_name=new_name, **kwargs) # pylint: disable=protected-access
file_system = self.get_file_system_client(new_name or name)
return file_system
Expand Down