Skip to content

[Tables] mypy #19001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seankane-msft merged 11 commits into from
Jun 2, 2021
Merged

[Tables] mypy #19001

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
81aebd6
type hints
seankane-msft May 10, 2021
0578a70
mypy fixes
seankane-msft May 10, 2021
00423fe
adding small fix
seankane-msft May 17, 2021
b6d95c3
fixed more async issues
seankane-msft May 24, 2021
26a8f5f
passing mypy
seankane-msft May 28, 2021
1b01abd
adding pylint changes
seankane-msft Jun 1, 2021
c5a9d2d
more lint fixes
seankane-msft Jun 1, 2021
461996d
caught another one
seankane-msft Jun 1, 2021
1c7f4eb
fixing merge conflicts
seankane-msft Jun 2, 2021
098d9cd
fixes for py3.7
seankane-msft Jun 2, 2021
64372ae
removal
seankane-msft Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes for py3.7
  • Loading branch information
@seankane-msft
seankane-msft committed Jun 2, 2021
commit 098d9cd8bc9387fc869861fbc9c3c188159f133a
6 changes: 3 additions & 3 deletions sdk/tables/azure-data-tables/azure/data/tables/_table_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ def create_entity(
"""
entity = _add_entity_properties(entity)
try:
metadata, content = self._client.table.insert_entity(
metadata, content = self._client.table.insert_entity( # type: ignore
table=self.table_name,
table_entity_properties=entity, # type: ignore
cls=kwargs.pop("cls", _return_headers_and_deserialized),
Expand Down Expand Up @@ -640,7 +640,7 @@ def upsert_entity(
metadata = None
content = None
if mode is UpdateMode.MERGE:
metadata, content = self._client.table.merge_entity(
metadata, content = self._client.table.merge_entity( # type: ignore
table=self.table_name,
partition_key=partition_key,
row_key=row_key,
Expand All @@ -649,7 +649,7 @@ def upsert_entity(
**kwargs
)
elif mode is UpdateMode.REPLACE:
metadata, content = self._client.table.update_entity(
metadata, content = self._client.table.update_entity( # type: ignore
table=self.table_name,
partition_key=partition_key,
row_key=row_key,
Expand Down
6 changes: 3 additions & 3 deletions sdk/tables/azure-data-tables/azure/data/tables/aio/_table_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ async def create_entity(
"""
entity = _add_entity_properties(entity)
try:
metadata, content = await self._client.table.insert_entity(
metadata, content = await self._client.table.insert_entity( # type: ignore
table=self.table_name,
table_entity_properties=entity, # type: ignore
cls=kwargs.pop("cls", _return_headers_and_deserialized),
Expand Down Expand Up @@ -621,7 +621,7 @@ async def upsert_entity(
metadata = None
content = None
if mode is UpdateMode.MERGE:
metadata, content = await self._client.table.merge_entity(
metadata, content = await self._client.table.merge_entity( # type: ignore
table=self.table_name,
partition_key=partition_key,
row_key=row_key,
Expand All @@ -630,7 +630,7 @@ async def upsert_entity(
**kwargs
)
elif mode is UpdateMode.REPLACE:
metadata, content = await self._client.table.update_entity(
metadata, content = await self._client.table.update_entity( # type: ignore
table=self.table_name,
partition_key=partition_key,
row_key=row_key,
Expand Down