[AutoPR] restapi_auto_network/resource-manager #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lmazuel merged 6 commits into master from restapi_auto_network/resource-manager

Mar 7, 2018

Member

lmazuel commented Feb 8, 2018

No description provided.

lmazuel added ARM ServicePR labels

codecov-io commented Feb 8, 2018 •

edited

Loading

Codecov Report

Merging #1933 into master will increase coverage by 0.43%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1933      +/-   ##
==========================================
+ Coverage   53.08%   53.51%   +0.43%     
==========================================
  Files        4774     5135     +361     
  Lines      119517   123409    +3892     
==========================================
+ Hits        63440    66040    +2600     
- Misses      56077    57369    +1292

Impacted Files	Coverage Δ
...rk/azure/mgmt/network/network_management_client.py	`31.53% <0%> (-3.21%)`	⬇️
...etwork/v2017_11_01/operations/routes_operations.py	`92.72% <0%> (-3.77%)`	⬇️
...tions/express_route_circuit_peerings_operations.py	`92.72% <0%> (-3.77%)`	⬇️
...2017_11_01/operations/security_rules_operations.py	`92.72% <0%> (-3.77%)`	⬇️
...express_route_circuit_authorizations_operations.py	`92.72% <0%> (-3.77%)`	⬇️
...twork/v2017_11_01/operations/subnets_operations.py	`91.96% <0%> (-3.73%)`	⬇️
...2017_11_01/operations/load_balancers_operations.py	`76.36% <0%> (-0.83%)`	⬇️
...1/operations/network_security_groups_operations.py	`76.36% <0%> (-0.83%)`	⬇️
.../v2017_11_01/operations/route_tables_operations.py	`76.36% <0%> (-0.83%)`	⬇️
...17_11_01/operations/virtual_networks_operations.py	`71.63% <0%> (-0.54%)`	⬇️
... and 514 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe33d1...0ece8ce. Read the comment docs.

This was referenced Feb 16, 2018

Updated network watcher swagger and examples for 2018-01-01 version Azure/azure-rest-api-specs#2508

Merged

appgw swagger examples Azure/azure-rest-api-specs#2503

Merged

AutorestCI mentioned this pull request

ExpressRoute swagger examples Azure/azure-rest-api-specs#2557

Closed

10 tasks

Member Author

lmazuel commented Feb 28, 2018

@AutorestCI rebase

Contributor

AutorestCI commented Feb 28, 2018

Rebase done and pushed to the branch

AutorestCI force-pushed the restapi_auto_network/resource-manager branch from f75941d to 417085e Compare

February 28, 2018 18:22

lmazuel and others added 2 commits

March 6, 2018 16:49


          Catch-up Network as of 2018-02-08

6c216ca


          [AutoPR network/resource-manager] Updated network watcher swagger and…

facae9e

… examples for 2018-01-01 version (#2004)

* Generated from 1fb08449cc9f20646435d3b498949a507447c755

Fixed Linter errors

* Generated from 6a2b7a0d90b4aeb9fcc7f0e0bcd01cf73f39abbf

Fixed Linter errors: iteration 2

lmazuel force-pushed the restapi_auto_network/resource-manager branch from 417085e to facae9e Compare

March 7, 2018 00:49

Contributor

AutorestCI commented Mar 7, 2018 •

edited

Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-network

You can install the package azure-mgmt-network of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_network/resource-manager#egg=azure-mgmt-network&subdirectory=azure-mgmt-network"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_network/resource-manager#egg=azure-mgmt-network&subdirectory=azure-mgmt-network"

If you have a local clone of this repository, you can also do:

git checkout restapi_auto_network/resource-manager
pip install -e ./azure-mgmt-network

Or build a wheel file to distribute for testing:

git checkout restapi_auto_network/resource-manager
pip wheel --no-deps ./azure-mgmt-network

Direct download

Your files can be directly downloaded here:


          Prepare azure-mgmt-network 2.0.0rc1

fae8723

annatisch reviewed

View reviewed changes

azure-mgmt-network/HISTORY.rst Outdated

    
              **Breaking changes**

              This version introduces a new generation of code generator that *might* introduce breaking changes.

Member

annatisch Mar 7, 2018

This version uses a next-generation code generator that might introduce breaking changes.

azure-mgmt-network/HISTORY.rst Outdated

    
              This version introduces a new generation of code generator that *might* introduce breaking changes. 

              - Model signatures are now using only keywords-arguments syntax. Every positional arguments are required to be rewritten as keywords-arguments.

Member

annatisch Mar 7, 2018

Model signatures now use only keyword-argument syntax. All positional arguments must be re-written as keyword-arguments.

azure-mgmt-network/HISTORY.rst Outdated

    
              - Model signatures are now using only keywords-arguments syntax. Every positional arguments are required to be rewritten as keywords-arguments.

                To keep auto-completion in most cases, models are now generated for Python 2 and Python 3. Python 3 uses the "*" syntax for keyword-only arguments.

              - Enum type are now using the "str" mixin (`class AzureEnum(str, Enum)`) to improve experiences when unkown enum are met. This is not a breaking change,

Member

annatisch Mar 7, 2018

Enum types now use the "str" mixin (class AzureEnum(str, Enum)) to improve the behavior when unrecognized enum values are encountered.

azure-mgmt-network/HISTORY.rst Outdated

    
              - Model signatures are now using only keywords-arguments syntax. Every positional arguments are required to be rewritten as keywords-arguments.

                To keep auto-completion in most cases, models are now generated for Python 2 and Python 3. Python 3 uses the "*" syntax for keyword-only arguments.

              - Enum type are now using the "str" mixin (`class AzureEnum(str, Enum)`) to improve experiences when unkown enum are met. This is not a breaking change,

                but documentation about mixin enum should be known:

Member

annatisch Mar 7, 2018

While this is not a breaking change, the distinctions are important, and are documented here:
https://docs.python.org/3/library/enum.html#others
At a glance.....

azure-mgmt-network/HISTORY.rst Outdated

    
              - New Long Running Operation:

                - Return type changes from `msrestazure.azure_operation.AzureOperationPoller` to `msrest.polling.LROPoller`. External API is the same.

                - Return type is now **always** a `msrest.polling.LROPoller`, whatever the optional parameters.

Member

annatisch Mar 7, 2018

regardless of the optional parameters used.

azure-mgmt-network/HISTORY.rst Outdated

    
                - Return type changes from `msrestazure.azure_operation.AzureOperationPoller` to `msrest.polling.LROPoller`. External API is the same.

                - Return type is now **always** a `msrest.polling.LROPoller`, whatever the optional parameters.

                - `raw=True` changes behavior. Instead of not polling and returning the initial call as `ClientRawResponse`, now this returns a LROPoller as well and the final

Member

annatisch Mar 7, 2018

The behavior has changed when using raw=True. Instead of returning the initial call result as ClientRawResponse without polling, now this returns an LROPoller. After polling, the final resource will be returned as a ClientRawResponse.

azure-mgmt-network/HISTORY.rst Outdated

    
                - Return type is now **always** a `msrest.polling.LROPoller`, whatever the optional parameters.

                - `raw=True` changes behavior. Instead of not polling and returning the initial call as `ClientRawResponse`, now this returns a LROPoller as well and the final 

                  resource is returned as a `ClientRawResponse`.

                - Adding `polling` parameter. Polling=True is the default and poll using ARM algorithm. Polling=False does not poll and return the initial call reponse.

Member

annatisch Mar 7, 2018

Newpolling parameter. The default behavior is polling=True which will poll using ARM algorithm. When polling=False, the response of the initial call will be returned without polling.

azure-mgmt-network/HISTORY.rst Outdated

    
                - `raw=True` changes behavior. Instead of not polling and returning the initial call as `ClientRawResponse`, now this returns a LROPoller as well and the final 

                  resource is returned as a `ClientRawResponse`.

                - Adding `polling` parameter. Polling=True is the default and poll using ARM algorithm. Polling=False does not poll and return the initial call reponse.

                - Polling parameter accepts instances of subclasses of `msrest.polling.PollingMethod`.

Member

annatisch Mar 7, 2018

polling parameter ...

azure-mgmt-network/HISTORY.rst Outdated

    
                  resource is returned as a `ClientRawResponse`.

                - Adding `polling` parameter. Polling=True is the default and poll using ARM algorithm. Polling=False does not poll and return the initial call reponse.

                - Polling parameter accepts instances of subclasses of `msrest.polling.PollingMethod`.

                - `add_done_callback` now does not fail if poller is done, but execute the callback right away.

Member

annatisch Mar 7, 2018

add_done_callback will no longer raise if called after polling is finished, but will instead execute the callback right away.

lmazuel added 3 commits

March 7, 2018 11:47


          ChangeLog feedback

dbb1ed3


          Latest Network with Autorest 3.0

fd8f750


          Add another breaking change to Network

0ece8ce

lmazuel merged commit c6aa88c into master

lmazuel deleted the restapi_auto_network/resource-manager branch

March 7, 2018 23:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels