[Core] Follow RFC 3339 datetime formatting for AzureJSONEncoder #20346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
Client
iscai-msft
reviewed
Aug 18, 2021
| else: | ||
| iso_formatted = o.astimezone(TZ_UTC).isoformat() | ||
| # Replace the trailing "+00:00" UTC offset with "Z" (RFC 3339: https://www.ietf.org/rfc/rfc3339.txt) | ||
| return iso_formatted.replace("+00:00", "Z") |
Contributor
There was a problem hiding this comment.
this is I think tangential to this specific PR, but I was looking into the msrest rfc serialization and we don't currently support that. Is this something I want to add?
msrest serialize rfc output:
serialize_rfc(isodate.parse_datetime("0001-01-01T00:00:00Z")) == 'Mon, 01 Jan 0001 00:00:00 GMT'azure.core.serialization
json.dumps(isodate.parse_datetime("0001-01-01T00:00:00Z"), cls=AzureJSONEncoder) == "0001-01-01T00:00:00Z"cc @lmazuel
Member
There was a problem hiding this comment.
Just to clear, your question has indeed mothing to do with @mccoyp 's PR :p . But yes, we could think about having a RFC HTTP header format serializer (not same RFC than here)
Contributor
There was a problem hiding this comment.
@mccoyp i'm totally wrong here please ignore me
Contributor
|
/azp run python - autorest - pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run python - autorest - pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run python - autorest - pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iscai-msft
approved these changes
Aug 19, 2021
Contributor
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
lgtm, should probably wait for @annatisch to review though
annatisch
approved these changes
Aug 31, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 31, 2021
…into update_lro_paging * 'main' of https://github.com/Azure/azure-sdk-for-python: [Core] Follow RFC 3339 datetime formatting for AzureJSONEncoder (Azure#20346) [Key Vault] Add 7.3-preview support for certificates (Azure#20477) Use dummy values and correct code rendering in README (Azure#20322) Use CredScan-suppressed dummy password in sample (Azure#20468) Fix type annotation in azure.storage.blob (Azure#20084) Adding static checks (Azure#20457) release_iseus_status_auto_reply (Azure#20441) Clarify LogsQueryClient query parameter description (Azure#20467) Sync eng/common directory with azure-sdk-tools for PR 1953 (Azure#20466) Skip eng common workflow enforcer for private repos (Azure#20462) remove iter_text and iter_lines (Azure#20460)
iscai-msft
added a commit
that referenced
this pull request
Aug 31, 2021
…into header_tuples * 'main' of https://github.com/Azure/azure-sdk-for-python: [Core] Follow RFC 3339 datetime formatting for AzureJSONEncoder (#20346)
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20190.