Skip to content

Conversation

@williexu
Copy link
Contributor

No description provided.

@williexu williexu requested a review from lmazuel as a code owner May 14, 2018 19:31
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented May 14, 2018

Codecov Report

Merging #2560 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
+ Coverage   55.17%   55.23%   +0.06%     
==========================================
  Files        6628     6548      -80     
  Lines      144734   143494    -1240     
==========================================
- Hits        79854    79261     -593     
+ Misses      64880    64233     -647
Impacted Files Coverage Δ
azure-mgmt-storage/azure/mgmt/storage/models.py 100% <ø> (ø) ⬆️
...azure/mgmt/storage/v2017_10_01/models/endpoints.py
..._10_01/models/storage_account_update_parameters.py
...torage/v2017_10_01/models/operation_display_py3.py
...storage/azure/mgmt/storage/v2017_10_01/__init__.py
...s/storage_account_regenerate_key_parameters_py3.py
...ge/v2017_10_01/models/service_specification_py3.py
...01/models/storage_account_create_parameters_py3.py
..._10_01/models/storage_account_create_parameters.py
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ff936...cd5e6c1. Read the comment docs.

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, it's why rc are good :)

@lmazuel lmazuel merged commit d06ade4 into Azure:master May 16, 2018
@lmazuel
Copy link
Member

lmazuel commented May 16, 2018

@williexu https://pypi.org/project/azure-mgmt-storage/2.0.0rc2/#description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants