Skip to content

Conversation

@lewu-msft
Copy link

adding test_vnet_operations

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lmazuel lmazuel changed the base branch from master to restapi_auto_3055 May 31, 2018 20:34
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credentials in PR

authority_uri = authority_host_uri + '/' + tenant
RESOURCE = 'https://management.core.windows.net/'
client_id = '565a758f-4919-40b8-af45-765cbb13664a'
client_secret = 'ycCDVcjcBuOwwroCdtlo4ZNzMoJ3iQ70JQExHmL8LnA='
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't do that in the test, you just made public this credentials and you're good to kill this SP now :(
Please read the tutorial for credentials:
https://github.com/Azure/azure-sdk-for-python/wiki/Contributing-to-the-tests

@lewu-msft
Copy link
Author

close this one. created a new one

@lewu-msft lewu-msft closed this Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants