App Configuration Provider Arch Review Fixes #28197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yVaultOptions to be Keyword only.
ghost
added
the
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
xiangyan99
reviewed
Jan 26, 2023
|
|
||
| def __init__(self, credential=None, secret_clients=None, secret_resolver=None): | ||
| # type: (TokenCredential, List[SecretClient], Callable) -> None | ||
| def __init__(self, *, credential=None, secret_clients=None, secret_resolver=None): |
Member
There was a problem hiding this comment.
Do you want to use something like:
Suggested change
| def __init__(self, *, credential=None, secret_clients=None, secret_resolver=None): | |
| def __init__(self, *, credential: Optional[TokenCredential]=None, secret_clients: Optional[List[SecretClient]]=None, secret_resolver: Optional[Callable[[str], str]]=None): |
?
Member
Author
There was a problem hiding this comment.
This is updated in the other PR as it changes to multiple @overloads
xiangyan99
reviewed
Jan 26, 2023
| "Key Vault %s does not contain secret %s" | ||
| % (key_vault_identifier.vault_url, key_vault_identifier.name) | ||
| ) | ||
| return referenced_client.get_secret(key_vault_identifier.name, version=key_vault_identifier.version).value |
Member
There was a problem hiding this comment.
Do you mean we want to raise ResourceNotFoundError rather than wrapping it into KeyVaultReferenceError?
Member
Author
There was a problem hiding this comment.
One of the comments brought up in the review board meeting was that we shouldn't use the customer errors unless we really need one for something. So, yes in this case raise whatever error the SDK throws.
Member
Author
|
See #28497 for all the new changes, including this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines