Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …

…into llaw/build_eventgrid
Azure · l0lawrence · May 19, 2023 · Apr 24, 2023 · Apr 24, 2023 · Apr 27, 2023
commit 9a124711c718b30846e878d73c2ddda9c8d54b74
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -68,7 +68,7 @@
 /sdk/attestation/azure-security-attestation/                         @anilba06 @Azure/azure-sdk-write-attestation @gkostal
 
 # PRLabel: %Batch
-/sdk/batch/                                                          @cRui861 @paterasMSFT @dpwatrous @gingi @zfengms @NickKouds
+/sdk/batch/                                                          @jingjlii @JJJessieWang @wanghoppe @dpwatrous @wiboris
 
 # PRLabel: %CognitiveServices
 /sdk/cognitiveservices/                                              @kristapratico

diff --git a/.github/workflows/event-processor.yml b/.github/workflows/event-processor.yml
@@ -11,8 +11,6 @@ on:
   # pull request merged is the closed event with github.event.pull_request.merged = true
   pull_request_target:
     types: [closed, labeled, opened, reopened, review_requested, synchronize, unlabeled]
-  pull_request_review:
-    types: [submitted]
 
 # This removes all unnecessary permissions, the ones needed will be set below.
 # https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
@@ -57,7 +55,7 @@ jobs:
         run: >
           dotnet tool install
           Azure.Sdk.Tools.GitHubEventProcessor
-          --version 1.0.0-dev.20230422.1
+          --version 1.0.0-dev.20230505.2
           --add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
           --global
         shell: bash

diff --git a/.github/workflows/scheduled-event-processor.yml b/.github/workflows/scheduled-event-processor.yml
@@ -34,7 +34,7 @@ jobs:
         run: >
           dotnet tool install
           Azure.Sdk.Tools.GitHubEventProcessor
-          --version 1.0.0-dev.20230422.1
+          --version 1.0.0-dev.20230505.2
           --add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
           --global
         shell: bash

diff --git a/.vscode/cspell.json b/.vscode/cspell.json
@@ -105,6 +105,8 @@
     "tools/azure-sdk-tools/devtools_testutils/fake_credentials.py",
     "tools/azure-sdk-tools/packaging_tools/**",
     "tools/azure-sdk-tools/setup.py",
+    "sdk/webpubsub/azure-messaging-webpubsubclient/azure/messaging/webpubsubclient/_serialization.py",
+    "sdk/webpubsub/azure-messaging-webpubsubclient/azure/messaging/webpubsubclient/_model_base.py",
     "tools/azure-sdk-tools/tests/test_servicemetadata.py"
   ],
   "words": [
@@ -174,6 +176,7 @@
     "dont",
     "dotenv",
     "dowhile",
+    "DPAPI",
     "dpkg",
     "dtlk",
     "dtlksd",
@@ -1463,6 +1466,12 @@
         "wday",
         "deseralize"
       ]
+    },
+    {
+      "filename": "sdk/webpubsub/azure-messaging-webpubsubclient/azure/messaging/webpubsubclient/_client.py",
+      "words": [
+        "awps"
+      ]
     }
   ],
   "allowCompoundWords": true

diff --git a/eng/common/pipelines/templates/steps/detect-api-changes.yml b/eng/common/pipelines/templates/steps/detect-api-changes.yml
@@ -1,6 +1,7 @@
 parameters:
   ArtifactPath: $(Build.ArtifactStagingDirectory)
   Artifacts: []
+  ArtifactName: 'packages'
 
 steps:
   - pwsh: |
@@ -20,6 +21,7 @@ steps:
         -PullRequestNumber $(System.PullRequest.PullRequestNumber)
         -RepoFullName $(Build.Repository.Name)
         -APIViewUri $(ApiChangeDetectRequestUrl)
+        -ArtifactName ${{ parameters.ArtifactName }}
       pwsh: true
     displayName: Detect API changes
     condition: and(succeededOrFailed(), eq(variables['Build.Reason'],'PullRequest'))
diff --git a/eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml b/eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml
@@ -19,5 +19,15 @@ steps:
             exit 1
           }
         }
-      displayName: Prevent changes to eng/common outside of azure-sdk-tools repo
+        if ((!"$(System.PullRequest.SourceBranch)".StartsWith("sync-.github/workflows")) -and "$(System.PullRequest.TargetBranch)" -match "^(refs/heads/)?$(DefaultBranch)$")
+        {
+          $filesInCommonDir  = & "eng/common/scripts/get-changedfiles.ps1" -DiffPath '.github/workflows/*'
+          if (($LASTEXITCODE -eq 0) -and ($filesInCommonDir.Count -gt 0))
+          {
+            Write-Host "##vso[task.LogIssue type=error;]Changes to files under '.github/workflows' directory should not be made in this Repo`n${filesInCommonDir}"
+            Write-Host "##vso[task.LogIssue type=error;]Please follow workflow at https://github.com/Azure/azure-sdk-tools/blob/main/doc/workflows/engsys_workflows.md"
+            exit 1
+          }
+        }
+      displayName: Prevent changes to eng/common and .github/workflows outside of azure-sdk-tools repo
       condition: and(succeeded(), ne(variables['Skip.EngCommonWorkflowEnforcer'], 'true'), not(endsWith(variables['Build.Repository.Name'], '-pr')))
diff --git a/eng/common/scripts/Delete-RemoteBranches.ps1 b/eng/common/scripts/Delete-RemoteBranches.ps1
@@ -10,6 +10,7 @@ param(
   $CentralRepoId,
   # We start from the sync PRs, use the branch name to get the PR number of central repo. E.g. sync-eng/common-(<branchName>)-(<PrNumber>). Have group name on PR number.
   # For sync-eng/common work, we use regex as "^sync-eng/common.*-(?<PrNumber>\d+).*$".
+  # For sync-.github/workflows work, we use regex as "^sync-.github/workflows.*-(?<PrNumber>\d+).*$".
   $BranchRegex,
   # Date format: e.g. Tuesday, April 12, 2022 1:36:02 PM. Allow to use other date format.
   [AllowNull()]
@@ -69,7 +70,7 @@ foreach ($res in $responses)
       LogError "No PR number found in the branch name. Please check the branch name [ $branchName ]. Skipping..."
       continue
     }
-      
+
     try {
       $centralPR = Get-GitHubPullRequest -RepoId $CentralRepoId -PullRequestNumber $pullRequestNumber -AuthToken $AuthToken
       LogDebug "Found central PR pull request: $($centralPR.html_url)"
@@ -78,7 +79,7 @@ foreach ($res in $responses)
         continue
       }
     }
-    catch 
+    catch
     {
       # If there is no central PR for the PR number, log error and skip.
       LogError "Get-GitHubPullRequests failed with exception:`n$_"
@@ -107,15 +108,15 @@ foreach ($res in $responses)
         LogDebug "The branch $branch last commit date [ $commitDate ] is newer than the date $LastCommitOlderThan. Skipping."
         continue
       }
-      
+
       LogDebug "Branch [ $branchName ] in repo [ $RepoId ] has a last commit date [ $commitDate ] that is older than $LastCommitOlderThan. "
     }
     catch {
       LogError "Get-GithubReferenceCommitDate failed with exception:`n$_"
       exit 1
     }
-  } 
-  
+  }
+
   try {
     if ($PSCmdlet.ShouldProcess("[ $branchName ] in [ $RepoId ]", "Deleting branches on cleanup script")) {
       Remove-GitHubSourceReferences -RepoId $RepoId -Ref $branch -AuthToken $AuthToken

diff --git a/eng/common/testproxy/target_version.txt b/eng/common/testproxy/target_version.txt
@@ -1 +1 @@
-1.0.0-dev.20230417.1
+1.0.0-dev.20230427.1
diff --git a/eng/common/testproxy/transition-scripts/README.md b/eng/common/testproxy/transition-scripts/README.md
@@ -46,7 +46,7 @@ To utilize this methodology, the user must set input argument `TestProxyExe` to
 
 Other requirements:
 
-- [x] Install [docker](https://docs.docker.com/engine/install/) or [podman](https://podman.io/getting-started/installation.html)
+- [x] Install [docker](https://docs.docker.com/engine/install/) or [podman](https://podman.io/)
 - [x] Set the environment variable `GIT_TOKEN` a valid token representing YOUR user
 
 ## Permissions

diff --git a/eng/pipelines/docindex.yml b/eng/pipelines/docindex.yml
@@ -74,6 +74,14 @@ jobs:
         displayName: Generate ToC for main branch
         condition: and(succeeded(), or(eq(variables['Build.Reason'], 'Schedule'), eq(variables['Force.MainUpdate'], 'true')))
 
+      - task: Powershell@2
+        inputs:
+          pwsh: true
+          filePath: eng/common/scripts/Verify-RequiredDocsJsonMembers.ps1
+          arguments: >-
+            -DocRepoLocation $(DocRepoLocation)
+        displayName: Verify Required Docs Json Members
+
       # Push changes to docs repo
       - template: /eng/common/pipelines/templates/steps/set-default-branch.yml
         parameters:
@@ -127,6 +135,14 @@ jobs:
             -OutputLocation $(DocRepoLocation)/docs-ref-mapping/reference-unified.yml
         displayName: Generate ToC for Daily Docs
 
+      - task: Powershell@2
+        inputs:
+          pwsh: true
+          filePath: eng/common/scripts/Verify-RequiredDocsJsonMembers.ps1
+          arguments: >-
+            -DocRepoLocation $(DocRepoLocation)
+        displayName: Verify Required Docs Json Members
+
       - template: /eng/common/pipelines/templates/steps/git-push-changes.yml
         parameters:
           BaseRepoBranch: $(DailyDocsBranchName)

diff --git a/eng/pipelines/templates/stages/platform-matrix-cryptography-dependency.json b/eng/pipelines/templates/stages/platform-matrix-cryptography-dependency.json
@@ -7,7 +7,7 @@
       "ubuntu-20.04": { "OSVmImage": "MMSUbuntu20.04", "Pool": "azsdk-pool-mms-ubuntu-2004-general" },
       "macos-11": { "OSVmImage": "macos-11", "Pool": "Azure Pipelines" }
     },
-    "PythonVersion": [ "pypy3.7", "3.8", "3.10"],
+    "PythonVersion": [ "pypy3.7", "3.8" ],
     "CoverageArg": "--disablecov"
   },
   "include": [
@@ -29,6 +29,17 @@
       "PythonVersion": "3.7",
       "CoverageArg": "--disablecov"
     },
+    {
+      "CoverageConfig": {
+        "ubuntu2004_310_coverage": {
+          "OSVmImage": "MMSUbuntu20.04",
+          "Pool": "azsdk-pool-mms-ubuntu-2004-general",
+          "PythonVersion": "3.10",
+          "CoverageArg": "",
+          "TestSamples": "false"
+        }
+      }
+    },
     {
       "Agent": {
         "windows-2022": { "OSVmImage": "MMS2022", "Pool": "azsdk-pool-mms-win-2022-general" }

diff --git a/eng/pipelines/templates/stages/platform-matrix.json b/eng/pipelines/templates/stages/platform-matrix.json
@@ -10,7 +10,7 @@
       "windows-2022": { "OSVmImage": "MMS2022", "Pool": "azsdk-pool-mms-win-2022-general" },
       "macos-11": { "OSVmImage": "macos-11", "Pool": "Azure Pipelines" }
     },
-    "PythonVersion": [ "pypy3.7", "3.7", "3.8", "3.9", "3.10" ],
+    "PythonVersion": [ "pypy3.7", "3.7", "3.8", "3.10" ],
     "CoverageArg": "--disablecov",
     "TestSamples": "false"
   },

diff --git a/eng/scripts/Language-Settings.ps1 b/eng/scripts/Language-Settings.ps1
@@ -346,6 +346,11 @@ function UpdateDocsMsPackages($DocConfigFile, $Mode, $DocsMetadata, $PackageSour
       continue
     }
 
+    if ($package.package_info.name.EndsWith("-nspkg")) {
+      Write-Host "Skipping $($package.package_info.name) because it's a namespace package."
+      continue
+    }
+
     # Do not filter by GA/Preview status because we want differentiate between
     # tracked and non-tracked packages
     $matchingPublishedPackageArray = $DocsMetadata.Where( { $_.Package -eq $packageName })
@@ -430,11 +435,15 @@ function UpdateDocsMsPackages($DocConfigFile, $Mode, $DocsMetadata, $PackageSour
   $remainingPackages = @()
   if ($Mode -eq 'preview') {
     $remainingPackages = $DocsMetadata.Where({
-      $_.VersionPreview.Trim() -and !$outputPackagesHash.ContainsKey($_.Package)
+      $_.VersionPreview.Trim() `
+      -and !$outputPackagesHash.ContainsKey($_.Package) `
+      -and !$_.Package.EndsWith("-nspkg")
     })
   } else {
     $remainingPackages = $DocsMetadata.Where({
-      $_.VersionGA.Trim() -and !$outputPackagesHash.ContainsKey($_.Package)
+      $_.VersionGA.Trim() `
+      -and !$outputPackagesHash.ContainsKey($_.Package) `
+      -and !$_.Package.EndsWith("-nspkg")
     })
   }
 

diff --git a/eng/tox/run_pylint.py b/eng/tox/run_pylint.py
@@ -70,6 +70,6 @@
         )
     except CalledProcessError as e:
         logging.error(
-            "{} exited with linting error {}".format(pkg_details.name, e.returncode)
+            "{} exited with linting error {}. Please see this link for more information https://aka.ms/azsdk/python/pylint-guide".format(pkg_details.name, e.returncode)
         )
         exit(1)
diff --git a/scripts/issue_helper/go.py b/scripts/issue_helper/go.py
@@ -1,6 +1,6 @@
 from common import Common
 
-_GO_OWNER = {'ArcturusZhang', 'lirenhe', 'Alancere', 'github-actions'}
+_GO_OWNER = {'ArcturusZhang', 'lirenhe', 'Alancere', 'github-actions[bot]'}
 _GO_REPO = 'Azure/azure-sdk-for-go'
 _FILE_OUT_NAME_GO = 'sdk_issue_go.md'
 

diff --git a/scripts/issue_helper/java.py b/scripts/issue_helper/java.py
@@ -1,6 +1,6 @@
 from common import Common
 
-_JAVA_OWNER = {'weidongxu-microsoft', 'haolingdong-msft', 'XiaofeiCao', 'github-actions'}
+_JAVA_OWNER = {'weidongxu-microsoft', 'haolingdong-msft', 'XiaofeiCao', 'github-actions[bot]'}
 _JAVA_REPO = 'Azure/azure-sdk-for-java'
 _FILE_OUT_NAME_JAVA = 'sdk_issue_java.md'
 

diff --git a/scripts/issue_helper/js.py b/scripts/issue_helper/js.py
@@ -1,6 +1,6 @@
 from common import Common
 
-_JS_OWNER = {'colawwj', 'qiaozha', 'lirenhe', 'MaryGao', 'github-actions'}
+_JS_OWNER = {'colawwj', 'qiaozha', 'lirenhe', 'MaryGao', 'github-actions[bot]'}
 _JS_REPO = 'Azure/azure-sdk-for-js'
 _FILE_OUT_NAME_JS = 'sdk_issue_js.md'
 

diff --git a/scripts/issue_helper/python.py b/scripts/issue_helper/python.py
@@ -5,7 +5,7 @@
 
 from common import Common
 
-_PYTHON_OWNER = {'msyyc', 'Wzb123456789', 'github-actions'}
+_PYTHON_OWNER = {'msyyc', 'Wzb123456789', 'github-actions[bot]'}
 _PYTHON_REPO = 'Azure/azure-sdk-for-python'
 _FILE_OUT_NAME_PYTHON = 'sdk_issue_python.md'
 

diff --git a/scripts/release_helper/python.py b/scripts/release_helper/python.py
@@ -19,7 +19,7 @@
 _MultiAPI = 'MultiAPI'
 # record published issues
 _FILE_OUT = 'published_issues_python.csv'
-_HINTS = ["FirstGA", "FirstBeta", "HoldOn", "OnTime"]
+_HINTS = ["FirstGA", "FirstBeta", "HoldOn", "OnTime", "ForCLI"]
 
 
 class IssueProcessPython(IssueProcess):

diff --git a/sdk/communication/azure-communication-callautomation/README.md b/sdk/communication/azure-communication-callautomation/README.md
@@ -24,11 +24,9 @@ pip install azure-communication-callautomation
 ## Key concepts
 | Name                 | Description                                                                                                                                                                                                                                                                                                                              |
 | -------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| CallAutomationClient | `CallAutomationClient` is the primary interface for developers using this client library. It can be used to initiate calls by `createCall` or `answerCall`.                                                                                                                                                                              |
-| CallConnectionClient | `CallConnectionClient` represents a ongoing call. Once the call is established with `createCall` or `answerCall`, further actions can be performed for the call, such as `transfer` or `addParticipant`.                                                                                                                                       |
-| CallMediaClient      | `CallMediaClient` can be used to do media related actions, such as `play`, to play media file. This can be retrieved from established `CallConnectionClient`.                                                                                                                                                                                        |
-| CallRecordingClient  | `CallRecordingClient` can be used to do recording related actions, such as `startRecording`. This can be retrieved from `CallAutomationClient`.                                                                                                                                                                                                |
-| Callback Events      | Callback events are events sent back during duration of the call. It gives information and state of the call, such as `CallConnected`. `CallbackUrl` must be provided during `createCall` and `answerCall`, and callback events will be sent to this url. You can use `callAutomationEventParser` to parse these events when it arrives. |
+| CallAutomationClient | `CallAutomationClient` is the primary interface for developers using this client library. It can be used to initiate calls by `createCall` or `answerCall`. It can also be used to do recording actions such as `startRecording`                                                                                                         |                                                                      |
+| CallConnectionClient | `CallConnectionClient` represents a ongoing call. Once the call is established with `createCall` or `answerCall`, further actions can be performed for the call, such as `transfer` or `play_media`.                                                                                                                                     |                                                                                                                                                               |
+| Callback Events      | Callback events are events sent back during duration of the call. It gives information and state of the call, such as `CallConnected`. `CallbackUrl` must be provided during `createCall` and `answerCall`, and callback events will be sent to this url. |
 | Incoming Call Event  | When incoming call happens (that can be answered with `answerCall`), incoming call eventgrid event will be sent. This is different from Callback events above, and should be setup on Azure portal. See [Incoming Call][incomingcall] for detail.                                                                                        |
 
 ## Examples
@@ -59,14 +57,20 @@ call_invite = CallInvite(target=user)
 callback_url = "https://<MY-EVENT-HANDLER-URL>/events"
 
 # send out the invitation, creating call
-response = client.create_call(call_invite, callback_url)
+result = client.create_call(call_invite, callback_url)
+
+# this id can be used to do further actions in the call
+call_connection_id = result.call_connection_id
 ```
 
 ### Play Media
 ```Python
-# from callconnection of response above, play media of media file
-my_file = FileSource(uri="https://<FILE-SOURCE>/<SOME-FILE>.wav")
-const response = call_connection.get_call_media().play_to_all(my_file)
+# using call connection id, get call connection
+call_connection = client.get_call_connection(call_connection_id)
+
+# from callconnection of result above, play media to all participants
+my_file = FileSource(url="https://<FILE-SOURCE>/<SOME-FILE>.wav")
+call_connection.play_to_all(my_file)
 ```
 
 ## Troubleshooting