Number lookup ga #33203
Merged
Number lookup ga #33203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update swagger and regenerate using autorest * update internal operation tests * regenerate autorest, add and record tests * Update changelog * update tests to account for phone number sanitization, update test recordings * update autorest generation * updates based on review comments * udpate tests/recordings * fix linting error * fix lint errors and test for async * update test recordings * update changelog, minor fixes to tests, and update to the recordings * update version in changelog to beta version * update version * update changelog * update changelog
ericasp16
requested review from
RoyHerrod,
danielav7,
miguhern and
whisper6284
as code owners
Member
|
/azp run python - communication - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
ericasp16
changed the base branch from
ericasp/number-lookup-preview
to
main
Member
Author
|
/azp run python - communication - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kashifkhan
reviewed
Nov 20, 2023
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Outdated
Show resolved
Hide resolved
kashifkhan
reviewed
Nov 20, 2023
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Outdated
Show resolved
Hide resolved
kashifkhan
reviewed
Nov 20, 2023
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Outdated
Show resolved
Hide resolved
kashifkhan
reviewed
Nov 20, 2023
...mmunication-phonenumbers/azure/communication/phonenumbers/aio/_phone_numbers_client_async.py
Show resolved
Hide resolved
ericasp16
changed the base branch from
main
to
ericasp/number-lookup-ga-staging
ericasp16
requested review from
ChenxiJiang333,
benbp,
iscai-msft,
msyyc,
scbedd and
weshaggard
as code owners
ericasp16
removed request for
Aashish93-stack,
ChenxiJiang333,
DouglasXiaoMS,
FlorianBorn71,
JJJessieWang,
LuChen-Microsoft,
MilesHolland,
TajiHarrisMicrosoft,
albertofori,
gracewilcox,
jalauzon-msft,
kdestin,
l0lawrence,
maximrytych-ms,
maykumar-msft,
mengaims,
mjafferi-msft,
msyyc,
nancy-mejia,
nisha-bhatia,
scbedd,
srnagar,
swathipil,
vincenttran-msft,
wangchao1230,
wiboris,
xinlian12 and
yogeshmo
ericasp16
added a commit
that referenced
this pull request
Mar 27, 2024
* Number lookup ga (#33203) GA implementation of the number lookup feature, releasing as a private preview first. This commit should cover the vast majority of the work needed, and is updated to incorporate feedback from the stewardship board. ---------- * Add number lookup to communication phonenumbers (#31053) * update swagger and regenerate using autorest * update internal operation tests * regenerate autorest, add and record tests * Update changelog * update tests to account for phone number sanitization, update test recordings * update autorest generation * updates based on review comments * udpate tests/recordings * fix linting error * fix lint errors and test for async * update test recordings * update changelog, minor fixes to tests, and update to the recordings * update version in changelog to beta version * update version * update changelog * update changelog * update generated files * update to GA verison for review * updated based on SDK review feedback * update to preview version, regenerate files with autorest * update test recordings * fix build issues * fix pylint errors, update tests * try fixing up tests * comment out failing call-automation test * fix pylint issues * update test files * Update setup.py upgrade the azure.core package --------- Co-authored-by: guoqing2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update azure-communication-phonenumbers SDK to support GA for number lookup feature
Swagger updates: Azure/azure-rest-api-specs#26294
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines