Skip to content

[Pylint] py_version and is_check_enabled edits #33743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
l0lawrence merged 5 commits into from
Feb 9, 2024
Merged

[Pylint] py_version and is_check_enabled edits #33743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3e97b8
py version improvement
l0lawrence Jan 5, 2024
f797d78
conflict
l0lawrence Jan 11, 2024
76b3dc5
conflict 2
l0lawrence Jan 11, 2024
ab2e39c
add py-version to pylintrc
kristapratico Feb 6, 2024
a26d1d9
Merge branch 'main' into py_version
kristapratico Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[MASTER]
py-version=3.8
ignore-patterns=test_*,conftest,setup
reports=no

Expand Down
2 changes: 1 addition & 1 deletion eng/tox/run_pylint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
logging.error(
"{} exited with linting error {}. Please see this link for more information https://aka.ms/azsdk/python/pylint-guide".format(pkg_details.name, e.returncode)
)
if args.next and in_ci() and is_check_enabled(args.target_package, "pylint"):
if args.next and in_ci():
from gh_tools.vnext_issue_creator import create_vnext_issue
create_vnext_issue(pkg_details.name, "pylint")

Expand Down
2 changes: 0 additions & 2 deletions eng/tox/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ commands =

[testenv:pylint]
description=Lints a package with pylint (version {[testenv:pylint]pylint_version})
basepython = python38
pylint_version=2.15.8
skipsdist = true
skip_install = true
Expand All @@ -102,7 +101,6 @@ commands =

[testenv:next-pylint]
description=Lints a package with pylint (version {[testenv:next-pylint]pylint_version})
basepython = python38
pylint_version=3.0.3
skipsdist = true
skip_install = true
Expand Down
1 change: 1 addition & 0 deletions pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[MASTER]
py-version=3.8
ignore-patterns=test_*,conftest,setup
reports=no

Expand Down