Skip to content

Update configure_azure_monitor signature and django sample #33834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremydvoss merged 4 commits into from
Jan 23, 2024
Merged

Update configure_azure_monitor signature and django sample #33834

jeremydvoss merged 4 commits into from
Jan 23, 2024

Conversation

@jeremydvoss
Copy link
Member

@jeremydvoss jeremydvoss commented Jan 12, 2024

Description

Update Django Sample putting configure_azure_monitor in each entry point. Updated configure_azure_monitor method signature to include instrumentation_options.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Monitor - Distro Monitor OpenTelemetry Distro label Jan 12, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 12, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

@jeremydvoss jeremydvoss force-pushed the docs branch 3 times, most recently from 75fa945 to 0611072 Compare January 18, 2024 20:33
@jeremydvoss jeremydvoss marked this pull request as ready for review January 18, 2024 22:41
@jeremydvoss jeremydvoss enabled auto-merge (squash) January 22, 2024 18:41
@jeremydvoss jeremydvoss merged commit 91811ab into Azure:main Jan 23, 2024
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-python that referenced this pull request Feb 16, 2024
@jeremydvoss @sofiar-msft
Update configure_azure_monitor signature and django sample (Azure#33834)
850e95f 
* Update Django samples and configure_azure_monitor method signature

* Ignore spelling in django binary file

* Add distro sqlite to match exporter
@jeremydvoss jeremydvoss mentioned this pull request Feb 29, 2024
Merged
@jeremydvoss jeremydvoss mentioned this pull request Apr 4, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

Assignees

No one assigned

Labels

Monitor - Distro Monitor OpenTelemetry Distro

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremydvoss @azure-sdk @lzchen