Skip to content

cleanup duplicated code gen ai sdk #34048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luigiw merged 19 commits into from
Feb 2, 2024
Merged

cleanup duplicated code gen ai sdk #34048

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
47aebde
remove duplicated
jingyizhu99 Jan 26, 2024
8e12f25
Merge branch 'main' into users/jingyizhu/rag/cleanup-duplicated-code-…
jingyizhu99 Jan 26, 2024
456f695
fix references
jingyizhu99 Jan 29, 2024
bdf7076
remove extra line/file used for testing
jingyizhu99 Jan 30, 2024
e7b2c17
from_metadata()
jingyizhu99 Jan 30, 2024
1028159
as_langchain_embeddings
jingyizhu99 Jan 30, 2024
6ed90c7
ignore llm in spelling checks
jingyizhu99 Jan 30, 2024
bc46db9
ignore llms
jingyizhu99 Jan 30, 2024
aa0241c
type checking
jingyizhu99 Jan 31, 2024
a5801d2
fix type checking
jingyizhu99 Jan 31, 2024
76076d0
ignore index
jingyizhu99 Jan 31, 2024
ef10eaf
ignore type check
jingyizhu99 Jan 31, 2024
1b9ab88
Merge branch 'main' into users/jingyizhu/rag/cleanup-duplicated-code-…
jingyizhu99 Jan 31, 2024
766d0cd
ignore[no-redef]
jingyizhu99 Jan 31, 2024
27fc521
Merge branch 'main' into users/jingyizhu/rag/cleanup-duplicated-code-…
jingyizhu99 Jan 31, 2024
941527d
revoke deletion of _functions.py
jingyizhu99 Feb 1, 2024
b51b143
Merge branch 'main' into users/jingyizhu/rag/cleanup-duplicated-code-…
jingyizhu99 Feb 1, 2024
d7ea4dc
resolve unexpected change from merge
jingyizhu99 Feb 1, 2024
0e66b9d
remove extra whitespaces
jingyizhu99 Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ignore[no-redef]
  • Loading branch information
@jingyizhu99
jingyizhu99 committed Jan 31, 2024
commit 766d0cdd0e72e0ba93ec94dcb13f1e89c3a2cd6e
2 changes: 1 addition & 1 deletion sdk/ai/azure-ai-generative/azure/ai/generative/index/_embeddings/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,7 @@ def add_doc(doc_id, emb_doc, documents):
import_faiss_or_so_help_me = dependable_faiss_import
elif engine.endswith("indexes.faiss.FaissAndDocStore"):
from azure.ai.generative.index._docstore import FileBasedDocstore
from azure.ai.generative.index._indexes.faiss import FaissAndDocStore, import_faiss_or_so_help_me
from azure.ai.generative.index._indexes.faiss import FaissAndDocStore, import_faiss_or_so_help_me # type: ignore[no-redef]

def add_doc(doc_id, emb_doc, documents):
documents.append(
Expand Down