updates

sdk/identity/azure-identity/azure/identity/_internal/msal_credentials.py

@@ -51,6 +51,10 @@ def __init__(
 
         self._cache = kwargs.pop("_cache", None)
         self._cae_cache = kwargs.pop("_cae_cache", None)
+        if self._cache or self._cae_cache:
+            self._custom_cache = True
+        else:
+            self._custom_cache = False
         self._cache_options = kwargs.pop("cache_persistence_options", None)
 
         super(MsalCredential, self).__init__()
@@ -118,10 +122,16 @@ def __getstate__(self) -> Dict[str, Any]:
         # Remove the non-picklable entries
         del state["_client_applications"]
         del state["_cae_client_applications"]
+        if not self._custom_cache:
+            del state["_cache"]
+            del state["_cae_cache"]
         return state
 
     def __setstate__(self, state: Dict[str, Any]) -> None:
         self.__dict__.update(state)
         # Re-create the unpickable entries
         self._client_applications = {}
         self._cae_client_applications = {}
+        if not self._custom_cache:
+            self._cache = None
+            self._cae_cache = None

sdk/identity/azure-identity/tests/test_pickling.py

@@ -4,11 +4,19 @@
 # ------------------------------------
 import pickle
 from azure.identity import DefaultAzureCredential
-
+from azure.identity._internal.msal_credentials import MsalCredential
 
 def test_pickle_dac():
     cred = DefaultAzureCredential()
     with open("data.pkl", "wb") as outfile:
         pickle.dump(cred, outfile)
     with open("data.pkl", "rb") as infile:
         data_loaded = pickle.load(infile)
+
+def test_pickle_msal_credential():
+    cred = MsalCredential(client_id="CLIENT_ID")
+    app = cred._get_app()
+    with open("data.pkl", "wb") as outfile:
+        pickle.dump(cred, outfile)
+    with open("data.pkl", "rb") as infile:
+        data_loaded = pickle.load(infile)