Skip to content

[Cosmos] Partition key not optional #34306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annatisch merged 5 commits into from
Feb 29, 2024
Merged

[Cosmos] Partition key not optional #34306

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c3675cc
partition key not optional
annatisch Feb 13, 2024
f24d847
Use typing alias
annatisch Feb 13, 2024
e52023b
PartitionKey is not optional
annatisch Feb 13, 2024
f42cd53
Updated PartitionKeyType
annatisch Feb 28, 2024
0781316
Fix pylint
annatisch Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PartitionKey is not optional
  • Loading branch information
@annatisch
annatisch authored Feb 13, 2024
commit e52023b9ee306ce137f6c031a1b0c28207f36a2e
4 changes: 2 additions & 2 deletions sdk/cosmos/azure-cosmos/azure/cosmos/aio/_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ async def read(
async def create_container(
self,
id: str,
partition_key: Optional[PartitionKey],
partition_key: PartitionKey,
*,
indexing_policy: Optional[Dict[str, str]] = None,
default_ttl: Optional[int] = None,
Expand Down Expand Up @@ -265,7 +265,7 @@ async def create_container(
@distributed_trace_async
async def create_container_if_not_exists(
self,
id: str, # pylint: disable=redefined-builtin
id: str,
partition_key: PartitionKey,
**kwargs: Any
) -> ContainerProxy:
Expand Down