Skip to content

[Storage] Expose services to be configurable for account SAS generation #34389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincenttran-msft merged 8 commits into from
Feb 23, 2024
Merged

[Storage] Expose services to be configurable for account SAS generation #34389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
72bfc0c
Expose Services to be configurable for account SAS generation
vincenttran-msft Feb 21, 2024
7652593
Nit
vincenttran-msft Feb 21, 2024
1686e15
Changelogs, tests for blob&file SAS token combo
vincenttran-msft Feb 22, 2024
c1967c4
Fix typehint to support str
vincenttran-msft Feb 22, 2024
70de866
Fix import
vincenttran-msft Feb 22, 2024
fa8fe9b
No network calls assert ss=
vincenttran-msft Feb 22, 2024
a982685
Remove service calls, unit test :D
vincenttran-msft Feb 23, 2024
555913d
Export Services, fix imports
vincenttran-msft Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove service calls, unit test :D
  • Loading branch information
@vincenttran-msft
vincenttran-msft committed Feb 23, 2024
commit a9826850daca421a12f548205224cb56e21b19cd
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blob/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "python",
"TagPrefix": "python/storage/azure-storage-blob",
"Tag": "python/storage/azure-storage-blob_ac924daf0e"
"Tag": "python/storage/azure-storage-blob_cdf4374dd9"
}
7 changes: 2 additions & 5 deletions sdk/storage/azure-storage-blob/tests/test_common_blob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2141,18 +2141,15 @@ def test_blob_service_sas(self, **kwargs):
assert blob_props is not None

@BlobPreparer()
@recorded_by_proxy
def test_multiple_services_sas(self, **kwargs):
storage_account_name = kwargs.pop("storage_account_name")
storage_account_key = kwargs.pop("storage_account_key")

self._setup(storage_account_name, storage_account_key)

# Act
token = self.generate_sas(
generate_account_sas,
self.bsc.account_name,
self.bsc.credential.account_key,
storage_account_name,
storage_account_key,
ResourceTypes(container=True, object=True, service=True),
AccountSasPermissions(read=True, list=True),
datetime.utcnow() + timedelta(hours=1),
Expand Down
13 changes: 3 additions & 10 deletions sdk/storage/azure-storage-blob/tests/test_common_blob_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2316,24 +2316,17 @@ async def test_account_sas_credential(self, **kwargs):
assert self.container_name == container_properties.name

@BlobPreparer()
@recorded_by_proxy_async
async def test_multiple_services_sas(self, **kwargs):
storage_account_name = kwargs.pop("storage_account_name")
storage_account_key = kwargs.pop("storage_account_key")

# Arrange
await self._setup(storage_account_name, storage_account_key)

account_sas_permission = AccountSasPermissions(read=True, write=True, delete=True, add=True,
permanent_delete=True, list=True)

# Act
token = self.generate_sas(
generate_account_sas,
self.bsc.account_name,
self.bsc.credential.account_key,
storage_account_name,
storage_account_key,
ResourceTypes(container=True, object=True, service=True),
account_sas_permission,
AccountSasPermissions(read=True, list=True),
datetime.utcnow() + timedelta(hours=1),
services=Services(blob=True, fileshare=True)
)
Expand Down