update httppolicy checks in pipeline base

sdk/core/corehttp/corehttp/runtime/pipeline/_base.py

@@ -26,6 +26,7 @@
 from __future__ import annotations
 import logging
 from typing import Generic, TypeVar, Union, Any, List, Optional, Iterable, ContextManager
+from typing_extensions import TypeGuard
 
 from . import (
     PipelineRequest,
@@ -42,6 +43,17 @@
 _LOGGER = logging.getLogger(__name__)
 
 
+def is_http_policy(policy) -> TypeGuard[HTTPPolicy]:
+    if hasattr(policy, "send"):
+        return True
+    return False
+
+def is_sansio_http_policy(policy) -> TypeGuard[SansIOHTTPPolicy]:
+    if hasattr(policy, "on_request") or hasattr(policy, "on_response"):
+        return True
+    return False
+
+
 class _SansIOHTTPPolicyRunner(HTTPPolicy[HTTPRequestType, HTTPResponseType]):
     """Sync implementation of the SansIO policy.
 
@@ -123,10 +135,10 @@ def __init__(
         self._transport = transport
 
         for policy in policies or []:
-            if isinstance(policy, SansIOHTTPPolicy):
-                self._impl_policies.append(_SansIOHTTPPolicyRunner(policy))
-            elif policy:
+            if is_http_policy(policy):
                 self._impl_policies.append(policy)
+            elif is_sansio_http_policy(policy):
+                self._impl_policies.append(_SansIOHTTPPolicyRunner(policy))
         for index in range(len(self._impl_policies) - 1):
             self._impl_policies[index].next = self._impl_policies[index + 1]
         if self._impl_policies:

sdk/core/corehttp/corehttp/runtime/pipeline/_base_async.py

@@ -26,17 +26,24 @@
 from __future__ import annotations
 from types import TracebackType
 from typing import Any, Union, Generic, TypeVar, List, Optional, Iterable, Type
-from typing_extensions import AsyncContextManager
+from typing_extensions import AsyncContextManager, TypeGuard
 
 from . import PipelineRequest, PipelineResponse, PipelineContext
 from ..policies import AsyncHTTPPolicy, SansIOHTTPPolicy
+from ..pipeline._base import is_sansio_http_policy
 from ._tools_async import await_result as _await_result
 from ...transport import AsyncHttpTransport
 
 AsyncHTTPResponseType = TypeVar("AsyncHTTPResponseType")
 HTTPRequestType = TypeVar("HTTPRequestType")
 
 
+def is_async_http_policy(policy) -> TypeGuard[AsyncHTTPPolicy]:
+    if hasattr(policy, "send"):
+        return True
+    return False
+
+
 class _SansIOAsyncHTTPPolicyRunner(
     AsyncHTTPPolicy[HTTPRequestType, AsyncHTTPResponseType]
 ):  # pylint: disable=unsubscriptable-object
@@ -127,10 +134,10 @@ def __init__(
         self._transport = transport
 
         for policy in policies or []:
-            if isinstance(policy, SansIOHTTPPolicy):
-                self._impl_policies.append(_SansIOAsyncHTTPPolicyRunner(policy))
-            elif policy:
+            if is_async_http_policy(policy):
                 self._impl_policies.append(policy)
+            elif is_sansio_http_policy(policy):
+                self._impl_policies.append(_SansIOAsyncHTTPPolicyRunner(policy))
         for index in range(len(self._impl_policies) - 1):
             self._impl_policies[index].next = self._impl_policies[index + 1]
         if self._impl_policies: