Skip to content

Conversation

@pvaneck
Copy link
Member

@pvaneck pvaneck commented Mar 4, 2024

The swagger file commit SHAs are updated and the code is regenerated.

@github-actions github-actions bot added the Monitor Monitor, Monitor Ingestion, Monitor Query label Mar 4, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

The swagger file are updated and the code is regenerated.

Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck force-pushed the query-swagger-update branch from b50de14 to b3d2262 Compare March 8, 2024 22:32
@pvaneck
Copy link
Member Author

pvaneck commented Mar 8, 2024

/azp run python - monitor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pvaneck pvaneck marked this pull request as ready for review March 8, 2024 23:29
@pvaneck pvaneck requested a review from a team as a code owner March 8, 2024 23:29
@xiangyan99
Copy link
Member

@pvaneck
Copy link
Member Author

pvaneck commented Mar 9, 2024

Do we want to expose something like https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/search/azure-search-documents/azure/search/documents/_api_versions.py?

I think in the next API version updates, this will be a good idea. This is the first API version where all the metrics APIs are aligned under the same version, and going forward the versions should update in sync. I'll save it for the next time the version is updated.

@xiangyan99
Copy link
Member

Do we want to expose something like https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/search/azure-search-documents/azure/search/documents/_api_versions.py?

I think in the next API version updates, this will be a good idea. This is the first API version where all the metrics APIs are aligned under the same version, and going forward the versions should update in sync. I'll save it for the next time the version is updated.

I am a little confused, didn't we support api version 2023-10-01?

@pvaneck
Copy link
Member Author

pvaneck commented Mar 9, 2024

I am a little confused, didn't we support api version 2023-10-01?

Most metrics query operations did support 2023-10-01, but metric namespace operations used 2017-12-01-preview. This new updated version aligns all metrics api versions to be the same, and I don't want to create an enum for 2023-10-01 if not all metrics operations support it. (The metrics api versions were in a bit of a messy state that is now corrected)

@xiangyan99
Copy link
Member

I am a little confused, didn't we support api version 2023-10-01?

Most metrics query operations did support 2023-10-01, but metric namespace operations used 2017-12-01-preview. This new updated version aligns all metrics api versions to be the same, and I don't want to create an enum for 2023-10-01 if not all metrics operations support it. (The metrics api versions were in a bit of a messy state that is now corrected)

Do you mean we made a GA release on preview API version? Is it by design?

@pvaneck
Copy link
Member Author

pvaneck commented Mar 11, 2024

Do you mean we made a GA release on preview API version? Is it by design?

Yes, specifically for the arm metrics namespaces endpoint. Not sure the history behind this decision since this was well before my time, but now action has been taken to better align with Azure policies (i.e. versioning uniformly, not using preview in a GA).

@xiangyan99
Copy link
Member

Do you mean we made a GA release on preview API version? Is it by design?

Yes, specifically for the arm metrics namespaces endpoint. Not sure the history behind this decision since this was well before my time, but now action has been taken to better align with Azure policies (i.e. versioning uniformly, not using preview in a GA).

Do you mean we made a GA release on preview API version? Is it by design?

Yes, specifically for the arm metrics namespaces endpoint. Not sure the history behind this decision since this was well before my time, but now action has been taken to better align with Azure policies (i.e. versioning uniformly, not using preview in a GA).

So the new API 2024-02-01 is fully compatible with old ones, 2023-10-01 & 2017-12-01-preview? Can user explicitly specify old versions?

@pvaneck
Copy link
Member Author

pvaneck commented Mar 11, 2024

So the new API 2024-02-01 is fully compatible with old ones, 2023-10-01 & 2017-12-01-preview? Can user explicitly specify old versions?

Yea, 2024-02-01 has the same apis as 2023-10-01 and 2017-12-01-preview for metrics. Some context here: Azure/azure-rest-api-specs#27559 (comment)

A user can still explicitly specify old versions with the api_version kwarg for each operation. Older versions still work.

@pvaneck pvaneck merged commit 8f8ec65 into Azure:main Mar 12, 2024
@pvaneck pvaneck deleted the query-swagger-update branch March 12, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor Monitor, Monitor Ingestion, Monitor Query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants