Skip to content

MoMo api review changes #34670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
banibrata-de merged 2 commits into from
Mar 7, 2024
Merged

MoMo api review changes #34670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3eeb0e
api review
nemanjarajic Mar 6, 2024
ab551db
fix
nemanjarajic Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions sdk/ml/azure-ai-ml/azure/ai/ml/entities/_monitoring/thresholds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,6 @@ def _get_default_thresholds(cls) -> "NumericalDriftMetrics":
normalized_wasserstein_distance=0.1,
)

@classmethod
def defaults(cls) -> "NumericalDriftMetrics":
return cls._get_default_thresholds()


class CategoricalDriftMetrics(RestTranslatableMixin):
"""Categorical Drift Metrics
Expand Down Expand Up @@ -166,13 +162,6 @@ def _get_default_thresholds(cls) -> "CategoricalDriftMetrics":
jensen_shannon_distance=0.1,
)

@classmethod
def defaults(cls) -> "CategoricalDriftMetrics":
return cls._get_default_thresholds()

def get_name_and_threshold(self) -> Tuple:
return self._find_name_and_threshold()


class DataDriftMetricThreshold(MetricThreshold):
"""Data drift metric threshold
Expand Down Expand Up @@ -241,8 +230,8 @@ def _from_rest_object(cls, obj: DataDriftMetricThresholdBase) -> "DataDriftMetri
@classmethod
def _get_default_thresholds(cls) -> "DataDriftMetricThreshold":
return cls(
numerical=NumericalDriftMetrics.defaults(),
categorical=CategoricalDriftMetrics.defaults(),
numerical=NumericalDriftMetrics._get_default_thresholds(),
categorical=CategoricalDriftMetrics._get_default_thresholds(),
)

def __eq__(self, other: Any) -> bool:
Expand Down Expand Up @@ -316,8 +305,8 @@ def _from_rest_object(cls, obj: PredictionDriftMetricThresholdBase) -> "Predicti
@classmethod
def _get_default_thresholds(cls) -> "PredictionDriftMetricThreshold":
return cls(
numerical=NumericalDriftMetrics.defaults(),
categorical=CategoricalDriftMetrics.defaults(),
numerical=NumericalDriftMetrics._get_default_thresholds(),
categorical=CategoricalDriftMetrics._get_default_thresholds(),
)

def __eq__(self, other: Any) -> bool:
Expand Down