Skip to content

Add live metrics collection of requests/dependencies/exceptions #34673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzchen merged 18 commits into from
Mar 11, 2024
Merged

Add live metrics collection of requests/dependencies/exceptions #34673

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c674549
move state
lzchen Feb 28, 2024
6ddd599
collection
lzchen Mar 4, 2024
e2df1e0
exceptions
lzchen Mar 5, 2024
fbe7c2b
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
lzchen Mar 5, 2024
7c031c4
Update CHANGELOG.md
lzchen Mar 5, 2024
bc4a40a
utils
lzchen Mar 6, 2024
d6901b4
sample
lzchen Mar 6, 2024
b1769dc
sample
lzchen Mar 6, 2024
8c104eb
documentingress
lzchen Mar 6, 2024
d4ebbfd
feedback
lzchen Mar 8, 2024
be403e4
Update _utils.py
lzchen Mar 8, 2024
aeaa0d9
record span
lzchen Mar 8, 2024
b979900
log_record
lzchen Mar 8, 2024
81f8aec
convert
lzchen Mar 8, 2024
f556415
utils
lzchen Mar 8, 2024
ff42bc0
lint
lzchen Mar 8, 2024
0555786
lint
lzchen Mar 11, 2024
b1f5fbe
lint
lzchen Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@lzchen
lzchen committed Mar 11, 2024
commit 05557863f726bd1991078be97fdb33f4e7e6dcf2
3 changes: 1 addition & 2 deletions ...-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_live_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,7 @@ def _record_span(self, span: ReadableSpan) -> None:
_append_quickpulse_document(document)
duration_ms = 0
if span.end_time and span.start_time:
# mypy: disable-error-code="assignment"
duration_ms = (span.end_time - span.start_time) / 1e9
duration_ms = (span.end_time - span.start_time) / 1e9 # type: ignore
# TODO: Spec out what "success" is
success = span.status.is_ok

Expand Down
2 changes: 2 additions & 0 deletions ...tor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from azure.monitor.opentelemetry.exporter._quickpulse._live_metrics import _QuickpulseManager


# pylint: disable=protected-access
class _QuickpulseLogRecordProcessor(LogRecordProcessor):

def emit(self, log_data: LogData) -> None:
Expand All @@ -22,6 +23,7 @@ def force_flush(self, timeout_millis: int = 30000):
super().force_flush(timeout_millis=timeout_millis)


# pylint: disable=protected-access
class _QuickpulseSpanProcessor(SpanProcessor):

def on_end(self, span: ReadableSpan) -> None:
Expand Down
8 changes: 4 additions & 4 deletions ...monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ def _get_span_document(span: ReadableSpan) -> Union[RemoteDependencyDocument, Re
duration = 0
if span.end_time and span.start_time:
duration = span.end_time - span.start_time
status_code = span.attributes.get(SpanAttributes.HTTP_STATUS_CODE, "")
grpc_status_code = span.attributes.get(SpanAttributes.RPC_GRPC_STATUS_CODE, "")
status_code = span.attributes.get(SpanAttributes.HTTP_STATUS_CODE, "") # type: ignore
grpc_status_code = span.attributes.get(SpanAttributes.RPC_GRPC_STATUS_CODE, "") # type: ignore
span_kind = span.kind
url = _get_url(span_kind, span.attributes)
if span_kind in (SpanKind.CLIENT, SpanKind.PRODUCER, SpanKind.INTERNAL):
Expand All @@ -98,8 +98,8 @@ def _get_span_document(span: ReadableSpan) -> Union[RemoteDependencyDocument, Re

# mypy: disable-error-code="assignment"
def _get_log_record_document(log_data: LogData) -> Union[ExceptionDocument, TraceDocument]:
exc_type = log_data.log_record.attributes.get(SpanAttributes.EXCEPTION_TYPE)
exc_message = log_data.log_record.attributes.get(SpanAttributes.EXCEPTION_MESSAGE)
exc_type = log_data.log_record.attributes.get(SpanAttributes.EXCEPTION_TYPE) # type: ignore
exc_message = log_data.log_record.attributes.get(SpanAttributes.EXCEPTION_MESSAGE) # type: ignore
if exc_type is not None or exc_message is not None:
document = ExceptionDocument(
document_type=_DocumentIngressDocumentType.Exception.value,
Expand Down