[SB] Link-Detach #34820
Merged
[SB] Link-Detach #34820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
approved these changes
Mar 18, 2024
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/aio/_link_async.py
Show resolved
Hide resolved
Member
|
We are raising a There is potentially another way to handle this by attaching right away (instead of closing the connection and going from scratch) when we receive such a detach. I wonder if doing that would cause some other scenario to fail |
swathipil
reviewed
Mar 18, 2024
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/aio/_link_async.py
Outdated
Show resolved
Hide resolved
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Member
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kashifkhan
approved these changes
Mar 20, 2024
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/link.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/aio/_link_async.py
Outdated
Show resolved
Hide resolved
swathipil
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of service initiated detach errors when the error condition is None as it was causing the code to stall after sending out the responding detach.
Repro is to disable an entity and within process-incoming-frames frame[2][0] if it is a "link-detach-forced" set frame[2] = None
frame -
<- DetachFrame(handle=2, closed=True, error=None)