Attempt to fix replace_dev_reqs for Storage extensions
#34888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Honestly this LGTM at a glance.. I just kicked the actual storage build from this branch to see anything else that may go wrong. |
Member
Author
|
Storage test failures are unrelated and caused by issue in feature branch. Looks like tests USING the extension in Blob are passing. |
jalauzon-msft
commented
Mar 25, 2024
scbedd
approved these changes
Mar 25, 2024
jalauzon-msft
added a commit
to jalauzon-msft/azure-sdk-for-python
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address #34265