Skip to content
Prev Previous commit
Next Next commit
Fix file-share test cases, add changelog entries
  • Loading branch information
vincenttran-msft committed Apr 30, 2024
commit 12b438209dc55d10152103a8f7074b3fbadba146
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-file-datalake/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## 12.16.0b1 (Unreleased)

### Features Added

- Updated OAuth implementation to use the AAD scope returned in a Bearer challenge.

## 12.15.0 (Unreleased)

Expand Down
5 changes: 3 additions & 2 deletions sdk/storage/azure-storage-file-share/tests/test_directory.py
Original file line number Diff line number Diff line change
Expand Up @@ -1393,8 +1393,9 @@ def test_bad_audience_directory_client(self, **kwargs):
audience=f'https://badaudience.file.core.windows.net'
)

# Will not raise ClientAuthenticationError despite bad audience due to Bearer Challenge
directory_client.exists()
# Assert
with pytest.raises(ClientAuthenticationError):
directory_client.exists()


# ------------------------------------------------------------------------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1494,7 +1494,8 @@ async def test_bad_audience_directory_client(self, **kwargs):
audience=f'https://badaudience.file.core.windows.net'
)

# Will not raise ClientAuthenticationError despite bad audience due to Bearer Challenge
await directory_client.exists()
# Assert
with pytest.raises(ClientAuthenticationError):
await directory_client.exists()

# ------------------------------------------------------------------------------
5 changes: 3 additions & 2 deletions sdk/storage/azure-storage-file-share/tests/test_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -3760,7 +3760,8 @@ def test_bad_audience_file_client(self, **kwargs):
audience=f'https://badaudience.file.core.windows.net'
)

# Will not raise ClientAuthenticationError despite bad audience due to Bearer Challenge
file_client.get_file_properties()
# Assert
with pytest.raises(ClientAuthenticationError):
file_client.exists()

# ------------------------------------------------------------------------------
5 changes: 3 additions & 2 deletions sdk/storage/azure-storage-file-share/tests/test_file_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -3876,5 +3876,6 @@ async def test_bad_audience_file_client(self, **kwargs):
audience=f'https://badaudience.file.core.windows.net'
)

# Will not raise ClientAuthenticationError despite bad audience due to Bearer Challenge
await file_client.get_file_properties()
# Assert
with pytest.raises(ClientAuthenticationError):
await file_client.exists()
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-queue/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## 12.11.0b1 (Unreleased)

### Features Added

- Updated OAuth implementation to use the AAD scope returned in a Bearer challenge.

## 12.10.0 (Unreleased)

Expand Down