Skip to content

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented May 16, 2024

Description

Iterates on #35670. Since automatically applying these patches universally is problematic for some test suites, this PR instead makes the fixtures available for easy use by anyone who needs them. Documentation is also updated to explain their purpose and show how to include them in the proxy startup fixtures that most tests already use.

This has been locally tested to confirm that the change is compatible with libraries that do and don't use azure-sdk-tools.

Storage CI run: https://dev.azure.com/azure-sdk/public/_build/results?buildId=3796135&view=results
Core CI run: https://dev.azure.com/azure-sdk/public/_build/results?buildId=3796137&view=results

cc @scbedd

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp requested a review from lmazuel as a code owner May 16, 2024 22:39
@mccoyp mccoyp requested a review from scbedd May 16, 2024 22:39
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool! Thanks McCoy!

@mccoyp
Copy link
Member Author

mccoyp commented May 17, 2024

/check-enforcer override

@mccoyp mccoyp merged commit f6b4e0c into Azure:main May 17, 2024
@mccoyp mccoyp deleted the sleep-patch-fixture branch May 17, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants