Skip to content

Autoinstrumentation rework #35890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydvoss merged 2 commits into from
Jun 5, 2024
Merged

Autoinstrumentation rework #35890

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ba9028
Configure exporters and sampler directly in configurator
jeremydvoss Jun 4, 2024
3a691cd
lint
jeremydvoss Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lint
  • Loading branch information
@jeremydvoss
jeremydvoss committed Jun 4, 2024
commit 3a691cd0409a6948ff517feb9fd13e6f1ce82050
2 changes: 1 addition & 1 deletion ...re-monitor-opentelemetry/azure/monitor/opentelemetry/_autoinstrumentation/configurator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def _configure(self, **kwargs):
kwargs.setdefault(TRACE_EXPORTER_NAMES_ARG, ["azure-monitor-opentelemetry-exporter"])
try:
sample_rate = float(environ.get("OTEL_TRACES_SAMPLER_ARG", 1.0))
except ValueError:
except ValueError:
sample_rate = 1.0
kwargs.setdefault(SAMPLER_ARG, ApplicationInsightsSampler(sample_rate))
if environ.get(OTEL_METRICS_EXPORTER, "").lower().strip() != "none":
Expand Down