Skip to content

Allow configuration of metric Views in distro #35932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydvoss merged 5 commits into from
Jun 6, 2024
Merged

Allow configuration of metric Views in distro #35932

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d511cb5
views
lzchen Jun 5, 2024
7c4c3a4
test
lzchen Jun 5, 2024
c17aeae
lint
lzchen Jun 5, 2024
c049222
Merge branch 'main' into views
lzchen Jun 6, 2024
80568db
Update _configure.py
lzchen Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@lzchen
lzchen committed Jun 5, 2024
commit c17aeaec7f9db7d07eef16209a73dfd923d87532
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
### Features Added

- Enable views configuration
([#35566](https://github.com/Azure/azure-sdk-for-python/pull/35566))
([#35932](https://github.com/Azure/azure-sdk-for-python/pull/35932))

### Breaking Changes

Expand Down
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def _setup_logging(configurations: Dict[str, ConfigurationValue]):

def _setup_metrics(configurations: Dict[str, ConfigurationValue]):
resource: Resource = configurations[RESOURCE_ARG] # type: ignore
views: List[View] = configurations[VIEWS_ARG]
views: List[View] = configurations[VIEWS_ARG] # type: ignore
metric_exporter = AzureMonitorMetricExporter(**configurations)
reader = PeriodicExportingMetricReader(metric_exporter)
meter_provider = MeterProvider(
Expand Down