Skip to content

add a new parameter allow_roleassignment_on_rg to allow/disallow role assignment on resource group level #35939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luigiw merged 9 commits into from
Jun 6, 2024
Merged

add a new parameter allow_roleassignment_on_rg to allow/disallow role assignment on resource group level #35939

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e977864
Python SDK System Datastore Auth AML
matferrari-msft Jun 4, 2024
11296b7
Python SDK System Datastore Auth AML
matferrari-msft Jun 4, 2024
f1aaaed
Python SDK System Datastore Auth AML
matferrari-msft Jun 4, 2024
e971bb4
SDK Updates
matferrari-msft Jun 4, 2024
baa5937
Add allow_roleassignment_on_rg for customer to determine whether to a…
jiewe Jun 5, 2024
dc44c32
update the type of allow_roleassignment_on_rg
jiewe Jun 6, 2024
f7e9465
update allow_roleassignment_on_rg to be boolean
jiewe Jun 6, 2024
8c1041e
address lint check errors
jiewe Jun 6, 2024
b94e85e
run black to fix the formatting issue
jiewe Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Python SDK System Datastore Auth AML
  • Loading branch information
@matferrari-msft
matferrari-msft committed Jun 4, 2024
commit 11296b71fb0aa54414b317b256ff98c21efb7956
2 changes: 1 addition & 1 deletion sdk/ml/azure-ai-ml/azure/ai/ml/_arm_deployments/arm_templates/workspace_base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@
"description": "Managed network settings to be used for the workspace. If not specified, isolation mode Disabled is the default"
}
},
"system_datastores_auth_mode": {
"systemDatastoresAuthMode": {
"type": "string",
"defaultValue": "accesskey",
"metadata": {
Expand Down
2 changes: 1 addition & 1 deletion sdk/ml/azure-ai-ml/azure/ai/ml/_arm_deployments/arm_templates/workspace_param.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"managedNetwork": {
"value": {}
},
"system_datastores_auth_mode": {
"systemDatastoresAuthMode": {
"value": "accesskey"
},
"spark_runtime_version" : {
Expand Down
2 changes: 1 addition & 1 deletion sdk/ml/azure-ai-ml/azure/ai/ml/operations/_workspace_operations_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ def _populate_arm_parameters(self, workspace: Workspace, **kwargs: Any) -> Tuple
_set_val(param["publicNetworkAccess"], workspace.public_network_access)

if workspace.system_datastores_auth_mode:
_set_val(param["system_datastores_auth_mode"], workspace.system_datastores_auth_mode)
_set_val(param["systemDatastoresAuthMode"], workspace.system_datastores_auth_mode)

if workspace.image_build_compute:
_set_val(param["imageBuildCompute"], workspace.image_build_compute)
Expand Down