Skip to content

[Identity] Implement new protocol for all credentials #36882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvaneck merged 9 commits into from
Sep 18, 2024
Merged

[Identity] Implement new protocol for all credentials #36882

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9d90e56
[Identity] Implement new protocol methods
pvaneck Sep 5, 2024
c4dfbbc
pytest skips
pvaneck Sep 12, 2024
cf0e44c
Bump core
pvaneck Sep 12, 2024
a32601d
update default base method name
pvaneck Sep 13, 2024
96ff4d2
Merge branch 'main' into identity-new-token-protocol
pvaneck Sep 13, 2024
76598c1
Handle chained pop scenario
pvaneck Sep 14, 2024
3e59581
chained updates
pvaneck Sep 16, 2024
c25e1eb
add some ignores
pvaneck Sep 17, 2024
56273c9
Changes based on feedback
pvaneck Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add some ignores 
Signed-off-by: Paul Van Eck <[email protected]>
  • Loading branch information
@pvaneck
pvaneck committed Sep 17, 2024
commit c25e1eb4b1e57fb3e63130cc6e44e3f2be585365
4 changes: 2 additions & 2 deletions sdk/identity/azure-identity/azure/identity/_internal/interactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ def _get_token_base(

# Check for arbitrary additional options to enable intermediary support for PoP tokens.
for key in options:
if key not in TokenRequestOptions.__annotations__:
kwargs.setdefault(key, options[key])
if key not in TokenRequestOptions.__annotations__: # pylint:disable=no-member
kwargs.setdefault(key, options[key]) # type: ignore

try:
token = self._acquire_token_silent(
Expand Down