Skip to content

Conversation

@xinlian12
Copy link
Member

@xinlian12 xinlian12 commented Sep 17, 2024

Second PR for exposingFeedRange in change feed query. In PR #36930, we have exposed feedRange as a str type, but it comes with perf penalty - for each read_feed_ranges response, we would have to always do the base64 encoding, and for each query_items_change_feed using feed_range we have to decode the string.

In this PR, we will expose a FeedRange class type

@xinlian12
Copy link
Member Author

/azp run python - cosmos - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

/azp run python - cosmos - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos

@xinlian12 xinlian12 force-pushed the exposeFeedRangeAsClassType branch from 74b2ef0 to 8eeff36 Compare September 18, 2024 05:02
@xinlian12 xinlian12 changed the base branch from main to users/xinlian/feature/feedRangeAndChangeFeed September 18, 2024 16:18
@xinlian12 xinlian12 marked this pull request as ready for review September 18, 2024 16:18
@xinlian12 xinlian12 requested review from a team and annatisch as code owners September 18, 2024 16:18
@xinlian12 xinlian12 closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants