Skip to content

Add default impl to handle token challenges #37652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 12 commits into from
Oct 4, 2024
Merged

Add default impl to handle token challenges #37652

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a245cee
Add default impl to handle token challenges
xiangyan99 Sep 30, 2024
c53a91b
update version
xiangyan99 Sep 30, 2024
fffee09
update
xiangyan99 Sep 30, 2024
fa65427
update
xiangyan99 Sep 30, 2024
6b12559
update
xiangyan99 Sep 30, 2024
bbfe516
update
xiangyan99 Oct 1, 2024
70eb72e
Update sdk/core/azure-core/azure/core/pipeline/policies/_utils.py
xiangyan99 Oct 3, 2024
3899b13
Update sdk/core/azure-core/azure/core/pipeline/policies/_utils.py
xiangyan99 Oct 3, 2024
70dd0d1
update
xiangyan99 Oct 3, 2024
4dbc840
Update sdk/core/azure-core/tests/test_utils.py
xiangyan99 Oct 3, 2024
dca906e
Update sdk/core/azure-core/azure/core/pipeline/policies/_utils.py
xiangyan99 Oct 3, 2024
ce6e329
update
xiangyan99 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update
  • Loading branch information
@xiangyan99
xiangyan99 committed Oct 3, 2024
commit ce6e3290774a09ec979ee882dcbec06fb8d894ed
13 changes: 7 additions & 6 deletions sdk/core/azure-core/azure/core/pipeline/policies/_authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,15 +201,16 @@ def on_challenge(
encoded_claims = get_challenge_parameter(headers, "Bearer", "claims")
if not encoded_claims:
return False
claims = base64.urlsafe_b64decode(encoded_claims).decode("utf-8")
if claims:
try:
try:
padding_needed = -len(encoded_claims) % 4
claims = base64.urlsafe_b64decode(encoded_claims + "=" * padding_needed).decode("utf-8")
if claims:
token = self._get_token(*self._scopes, claims=claims)
bearer_token = cast(Union["AccessToken", "AccessTokenInfo"], token).token
self._update_headers(request.http_request.headers, bearer_token)
request.http_request.headers["Authorization"] = "Bearer " + bearer_token
return True
except Exception: # pylint:disable=broad-except
return False
except Exception: # pylint:disable=broad-except
return False
return False

def on_response(
Expand Down
11 changes: 6 additions & 5 deletions sdk/core/azure-core/azure/core/pipeline/policies/_authentication_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,16 @@ async def on_challenge(
encoded_claims = get_challenge_parameter(headers, "Bearer", "claims")
if not encoded_claims:
return False
claims = base64.urlsafe_b64decode(encoded_claims).decode("utf-8")
if claims:
try:
try:
padding_needed = -len(encoded_claims) % 4
claims = base64.urlsafe_b64decode(encoded_claims + "=" * padding_needed).decode("utf-8")
if claims:
token = await self._get_token(*self._scopes, claims=claims)
bearer_token = cast(Union["AccessToken", "AccessTokenInfo"], token).token
request.http_request.headers["Authorization"] = "Bearer " + bearer_token
return True
except Exception: # pylint:disable=broad-except
return False
except Exception: # pylint:disable=broad-except
return False
return False

def on_response(
Expand Down