Skip to content

Handle changes in sdk or sdk/<service> that are not actually packages #37825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 3 commits into from
Oct 10, 2024
Merged

Handle changes in sdk or sdk/<service> that are not actually packages #37825

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fad5f4
handle changes to sdk/blah.txt or sdk/service/blah.txt
scbedd Oct 9, 2024
d540f9f
remove extraneous write-host
scbedd Oct 9, 2024
6ccad2a
remove more content
scbedd Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,24 @@ function Get-python-AdditionalValidationPackagesFromPackageSet {
return $startsWith
}

$changedServices = @()
foreach($file in $diffObj.ChangedFiles) {
$pathComponents = $file -split "/"
# handle changes only in sdk/<service>/<file>/<extension>
if ($pathComponents.Length -eq 3 -and $pathComponents[0] -eq "sdk") {
$changedServices += $pathComponents[1]
}

# handle any changes under sdk/<file>.<extension>
if ($pathComponents.Length -eq 2 -and $pathComponents[0] -eq "sdk") {
changedServices += "template"
}
}

$toolChanged = $diffObj.ChangedFiles | Where-Object { $_.StartsWith("tool")}
$engChanged = $diffObj.ChangedFiles | Where-Object { $_.StartsWith("eng")}
$othersChanged = $diffObj.ChangedFiles | Where-Object { isOther($_) }
$changedServices = $changedServices | Get-Unique

if ($toolChanged) {
$additionalPackages = @(
Expand Down Expand Up @@ -73,16 +88,21 @@ function Get-python-AdditionalValidationPackagesFromPackageSet {
$additionalValidationPackages += $additionalPackages
}

foreach ($changedService in $changedServices) {
$additionalPackages = $AllPkgProps | Where-Object { $_.ServiceDirectory -eq $changedService }
$additionalValidationPackages += $additionalPackages
}

$uniqueResultSet = @()
foreach($pkg in $additionalPackages) {
foreach ($pkg in $additionalValidationPackages) {
if ($uniqueResultSet -notcontains $pkg -and $LocatedPackages -notcontains $pkg) {
$pkg.IncludedForValidation = $true
$uniqueResultSet += $pkg
}
}

Write-Host "Returning additional packages for validation: $($uniqueResultSet.Count)"
foreach($pkg in $uniqueResultSet) {
foreach ($pkg in $uniqueResultSet) {
Write-Host " - $($pkg.Name)"
}

Expand Down