-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Allocation Id #37840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrm9084
merged 41 commits into
Azure:feature/azure-appconfiguration-provider/variants
from
mrm9084:AllocationId
Oct 11, 2024
Merged
Allocation Id #37840
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
6db8216
Adding Telemetry
mrm9084 acc62d9
Telemetry Support
mrm9084 c333311
fixing formatting
mrm9084 2893693
Update _azureappconfigurationprovider.py
mrm9084 6ade779
Update _azureappconfigurationproviderasync.py
mrm9084 3ec51ec
formatting
mrm9084 d1c5a17
changing doc style due to pylint-next
mrm9084 5595657
fixing kwargs docs
mrm9084 246d259
Formatting
mrm9084 07c771a
Review comments
mrm9084 26f5042
Changed label checking.
mrm9084 5d485ab
black format changes
mrm9084 c09247b
pylint
mrm9084 958761e
Update sdk/appconfiguration/azure-appconfiguration-provider/azure/app…
mrm9084 fac284f
added space checks
mrm9084 50755b0
Update conftest.py
mrm9084 ce64aca
Merge remote-tracking branch 'upstream/main' into TelemetrySupport
mrm9084 c727b1c
Merge branch 'main' into TelemetrySupport
mrm9084 33ae94e
moved telemetry to client wrapper
mrm9084 c8f3b40
fixing format
mrm9084 79c9053
Merge branch 'main' into TelemetrySupport
mrm9084 d9cd086
Merge remote-tracking branch 'upstream/main' into TelemetrySupport
mrm9084 0456c6d
updating after merge
mrm9084 411dd2e
Merge remote-tracking branch 'upstream/main' into TelemetrySupport
mrm9084 7e33ecb
fixing black issue
mrm9084 126937a
removing unused imports
mrm9084 3261601
AllocationId
mrm9084 963c0f4
Update CODEOWNERS
mrm9084 58cccc2
Merge branch 'main' into AllocationId
mrm9084 775df1a
Update CODEOWNERS
mrm9084 e5f6ed4
fixing issues
mrm9084 0f688d2
Merge branch 'AllocationId' of https://github.com/mrm9084/azure-sdk-f…
mrm9084 b73b002
Update _client_manager_base.py
mrm9084 923362f
Fixing configuration value empty in calc
mrm9084 274c372
fixing pylint
mrm9084 c4dd229
Merge branch 'main' into AllocationId
mrm9084 6421788
Update _constants.py
mrm9084 59b745c
Merge remote-tracking branch 'upstream/main' into AllocationId
mrm9084 185389d
review comments
mrm9084 e36cc7d
fixing allocation check
mrm9084 50fe5fe
format fix
mrm9084 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixing configuration value empty in calc
- Loading branch information
commit 923362f6e870acab4915444d2983e944304fe551
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the sorted_variant list is empty? The last character of allocation_id won't ";"