Skip to content

[Evaluation] Change RougeType to Enum #38131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ninghu merged 10 commits into from
Oct 29, 2024
Merged

[Evaluation] Change RougeType to Enum #38131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
969b336
Change RougeType to Enum
ninghu Oct 28, 2024
1d37207
update test recording
ninghu Oct 28, 2024
772dfcc
Merge branch 'main' into ninhu/rouge
ninghu Oct 29, 2024
6e1781f
update assets.json
ninghu Oct 29, 2024
9f4530b
Merge branch 'main' into ninhu/rouge
ninghu Oct 29, 2024
1afc3d0
Merge branch 'main' into ninhu/rouge
ninghu Oct 29, 2024
7735eb3
try to update recordings to fix the failed tests
ninghu Oct 29, 2024
b6fff43
update
ninghu Oct 29, 2024
99c3b14
revert assets.json
ninghu Oct 29, 2024
6aea38a
update
ninghu Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/evaluation/azure-ai-evaluation/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "python",
"TagPrefix": "python/evaluation/azure-ai-evaluation",
"Tag": "python/evaluation/azure-ai-evaluation_eb4989f81d"
"Tag": "python/evaluation/azure-ai-evaluation_e3ec13551e"
}
7 changes: 3 additions & 4 deletions sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_rouge/_rouge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@
from promptflow._utils.async_utils import async_run_allowing_running_loop

from azure.ai.evaluation._vendor.rouge_score import rouge_scorer
from azure.core import CaseInsensitiveEnumMeta


class RougeType(str, Enum, metaclass=CaseInsensitiveEnumMeta):
class RougeType(Enum):
"""
Enumeration of ROUGE (Recall-Oriented Understudy for Gisting Evaluation) types.
"""
Expand Down Expand Up @@ -38,8 +37,8 @@ def __init__(self, rouge_type: RougeType):
self._rouge_type = rouge_type

async def __call__(self, *, ground_truth: str, response: str, **kwargs):
scorer = rouge_scorer.RougeScorer(rouge_types=[self._rouge_type])
metrics = scorer.score(ground_truth, response)[self._rouge_type]
scorer = rouge_scorer.RougeScorer(rouge_types=[self._rouge_type.value])
metrics = scorer.score(ground_truth, response)[self._rouge_type.value]
return {
"rouge_precision": metrics.precision,
"rouge_recall": metrics.recall,
Expand Down