Skip to content

Fix __call__ Overload Types #38238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
needuv merged 11 commits into from
Nov 1, 2024
Merged

Fix __call__ Overload Types #38238

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
aee710e
Fix __call__ overload issues
needuv Oct 31, 2024
854a50a
fix typing issue
needuv Oct 31, 2024
c04786b
make query required for groundednesspro
needuv Nov 1, 2024
8b6ee67
fix a malformatted docstring
needuv Nov 1, 2024
6199584
fix some type hints and remove eval_last_turn from evaluators
needuv Nov 1, 2024
ecf3982
fix optional import
needuv Nov 1, 2024
fc60f2b
comment out eval last turn section
needuv Nov 1, 2024
9e20064
fix merge conflicts
needuv Nov 1, 2024
8f49321
get rid of string from type hint
needuv Nov 1, 2024
1a1d8c5
fix typo
needuv Nov 1, 2024
db9c96f
fix mypy errors
needuv Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix mypy errors
  • Loading branch information
@needuv
needuv committed Nov 1, 2024
commit db9c96fe4fcd468b7f3f199ca99d2e878a009b9e
4 changes: 2 additions & 2 deletions sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/simulator/_direct_attack_simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ async def __call__(
randomization_seed = randint(0, 1000000)

regular_sim = AdversarialSimulator(
azure_ai_project=cast(dict, self.azure_ai_project), credential=self.credential
azure_ai_project=self.azure_ai_project, credential=self.credential
)
regular_sim_results = await regular_sim(
scenario=scenario,
Expand All @@ -194,7 +194,7 @@ async def __call__(
randomize_order=False,
randomization_seed=randomization_seed,
)
jb_sim = AdversarialSimulator(azure_ai_project=cast(dict, self.azure_ai_project), credential=self.credential)
jb_sim = AdversarialSimulator(azure_ai_project=self.azure_ai_project, credential=self.credential)
jb_sim_results = await jb_sim(
scenario=scenario,
target=target,
Expand Down