Skip to content

Allocation id update #38242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrm9084 merged 4 commits into from
Oct 31, 2024
Merged

Allocation id update #38242

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1372cb8
updated calc to sort keys
mrm9084 Oct 23, 2024
f2030e2
Update CHANGELOG.md
mrm9084 Oct 23, 2024
e8f436a
Update _client_manager_base.py
mrm9084 Oct 31, 2024
0511f02
Merge branch 'feature/azure-appconfiguration-provider/variants' into …
mrm9084 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
updated calc to sort keys
  • Loading branch information
@mrm9084
mrm9084 committed Oct 23, 2024
commit 1372cb8eed8950c14301950219d0f8d223ae37a6
4 changes: 3 additions & 1 deletion ...n/azure-appconfiguration-provider/azure/appconfiguration/provider/_client_manager_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ def _generate_allocation_id(feature_flag_value: Dict[str, JSON]) -> Optional[str
for v in sorted_variants:
allocation_id += f"{base64.b64encode(v.get('name', '').encode()).decode()},"
if "configuration_value" in v:
allocation_id += f"{json.dumps(v.get('configuration_value', ''), separators=(',', ':'))}"
allocation_id += (
f"{json.dumps(v.get('configuration_value', ''), separators=(',', ':'), sort_keys=True)},"
)
allocation_id += ";"
if sorted_variants:
allocation_id = allocation_id[:-1]
Expand Down