Skip to content

RAI service input sanitization #38247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MilesHolland merged 8 commits into from
Nov 1, 2024
Merged

RAI service input sanitization #38247

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fedd717
escape eval inputs
MilesHolland Oct 31, 2024
b36f26b
new recordings and disable accidentally enabled test
MilesHolland Oct 31, 2024
7d8a02c
save recordings again
MilesHolland Oct 31, 2024
94c6e73
save recordings again again
MilesHolland Nov 1, 2024
067660b
save recordings again again again
MilesHolland Nov 1, 2024
1660eb4
update groundedness threshold
MilesHolland Nov 1, 2024
87e824d
Update sdk/evaluation/azure-ai-evaluation/tests/e2etests/test_builtin…
MilesHolland Nov 1, 2024
64969f6
correct new check
MilesHolland Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
new recordings and disable accidentally enabled test
  • Loading branch information
@MilesHolland
MilesHolland committed Oct 31, 2024
commit b36f26b9d6a2ae44ca1300397f09be0f04698e69
2 changes: 1 addition & 1 deletion sdk/evaluation/azure-ai-evaluation/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "python",
"TagPrefix": "python/evaluation/azure-ai-evaluation",
"Tag": "python/evaluation/azure-ai-evaluation_daf1ed16fc"
"Tag": "python/evaluation/azure-ai-evaluation_9fe808d351"
}
6 changes: 3 additions & 3 deletions sdk/evaluation/azure-ai-evaluation/tests/e2etests/test_evaluate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def _get_run_from_run_history(flow_run_id, ml_client, project_scope):
@pytest.mark.usefixtures("recording_injection", "recorded_test")
@pytest.mark.localtest
class TestEvaluate:
# @pytest.mark.skip(reason="Temporary skip to merge 37201, will re-enable in subsequent pr")
@pytest.mark.skip(reason="Temporary skip to merge 37201, will re-enable in subsequent pr")
def test_evaluate_with_groundedness_evaluator(self, model_config, data_file):
# data
input_data = pd.read_json(data_file, lines=True)
Expand Down Expand Up @@ -150,7 +150,7 @@ def test_evaluate_with_groundedness_evaluator(self, model_config, data_file):
assert row_result_df["outputs.f1_score.f1_score"][2] == 1
assert result["studio_url"] is None

# @pytest.mark.skip(reason="Temporary skip to merge 37201, will re-enable in subsequent pr")
@pytest.mark.skip(reason="Temporary skip to merge 37201, will re-enable in subsequent pr")
def test_evaluate_with_relative_data_path(self, model_config):
original_working_dir = os.getcwd()

Expand Down Expand Up @@ -401,7 +401,7 @@ def test_evaluate_with_groundedness_pro_evaluator(self, project_scope, data_conv
assert 0 <= convo_metrics.get("groundedness_pro.groundedness_pro_passing_rate") <= 1

# @pytest.mark.performance_test
# @pytest.mark.skip(reason="Temporary skip to merge 37201, will re-enable in subsequent pr")
@pytest.mark.skip(reason="Temporary skip to merge 37201, will re-enable in subsequent pr")
def test_evaluate_with_async_enabled_evaluator(self, model_config, data_file):
os.environ["AI_EVALS_BATCH_USE_ASYNC"] = "true"
fluency_eval = FluencyEvaluator(model_config)
Expand Down