Skip to content

cosmos-sdk-client doesn't need artifacts hardcoded #38272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 1 commit into from
Nov 1, 2024
Merged

cosmos-sdk-client doesn't need artifacts hardcoded #38272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions eng/pipelines/templates/stages/cosmos-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,4 @@ extends:
Path: sdk/cosmos/cosmos-emulator-matrix.json
Selection: all
GenerateVMJobs: true
Artifacts:
Copy link
Member

@benbp benbp Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scbedd do we want to make the parameter default value this instead of empty array? Or are there more artifacts? If it's just an empty array it will be hard to override in the runtime UI without knowing the required yaml format.

- name: azure-cosmos
safeName: azurecosmos
- name: azure-mgmt-cosmosdb
safeName: azuremgmtcosmosdb
Artifacts: ${{ parameters.Artifacts }}
Loading