Skip to content

Broker on mac support #38274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 8 commits into from
Nov 5, 2024
Merged

Broker on mac support #38274

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d2b146
Broker on mac support
xiangyan99 Nov 1, 2024
67c4abc
update
xiangyan99 Nov 1, 2024
3b998f5
update
xiangyan99 Nov 2, 2024
d87d56d
update
xiangyan99 Nov 4, 2024
dc7679d
update
xiangyan99 Nov 4, 2024
ed4b380
update
xiangyan99 Nov 4, 2024
c745c75
update readme
xiangyan99 Nov 4, 2024
26513a4
update
xiangyan99 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@xiangyan99
xiangyan99 committed Nov 4, 2024
commit dc7679d2f37af587221a9f12a8fdfe4424287976
2 changes: 1 addition & 1 deletion sdk/identity/azure-identity-broker/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### Features Added

- Added broker on MacOs support.
- Added broker on macOS support.

### Breaking Changes

Expand Down
27 changes: 13 additions & 14 deletions sdk/identity/azure-identity-broker/azure/identity/broker/_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,19 +217,18 @@ def _disable_broker_on_app(self, **kwargs: Any) -> msal.ClientApplication:
if not token_cache:
token_cache = self._initialize_cache(is_cae=bool(kwargs.get("enable_cae")))

if tenant_id not in client_applications_map:
client_applications_map[tenant_id] = app_class(
client_id=self._client_id,
client_credential=self._client_credential,
client_capabilities=capabilities,
authority="{}/{}".format(self._authority, tenant_id),
azure_region=self._regional_authority,
token_cache=token_cache,
http_client=self._client,
instance_discovery=self._instance_discovery,
enable_broker_on_windows=True,
enable_broker_on_mac=False,
enable_pii_log=self._enable_support_logging,
)
client_applications_map[tenant_id] = app_class(
client_id=self._client_id,
client_credential=self._client_credential,
client_capabilities=capabilities,
authority="{}/{}".format(self._authority, tenant_id),
azure_region=self._regional_authority,
token_cache=token_cache,
http_client=self._client,
instance_discovery=self._instance_discovery,
enable_broker_on_windows=False,
enable_broker_on_mac=False,
enable_pii_log=self._enable_support_logging,
)

return client_applications_map[tenant_id]