Skip to content

Add OpenTelemetry LoggingHandler conditionally #38549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzchen merged 5 commits into from
Nov 15, 2024
Merged

Add OpenTelemetry LoggingHandler conditionally #38549

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd1ab75
duplicate
lzchen Nov 14, 2024
bb383f7
cl
lzchen Nov 14, 2024
8ceb373
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
lzchen Nov 15, 2024
6a78821
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
lzchen Nov 15, 2024
7b97d6d
black
lzchen Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cl
  • Loading branch information
@lzchen
lzchen committed Nov 14, 2024
commit bb383f753fbafa0853482b5cf5f43ff4d64acef3
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
### Features Added

- Only add OpenTelemetry LoggingHandler if current logger does not have it
([#38371](https://github.com/Azure/azure-sdk-for-python/pull/38371))
([#38549](https://github.com/Azure/azure-sdk-for-python/pull/38549))

### Breaking Changes

Expand Down
1 change: 0 additions & 1 deletion sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ def _setup_logging(configurations: Dict[str, ConfigurationValue]):
# This is to prevent most duplicate logging telemetry
if not any(isinstance(handler, LoggingHandler) for handler in logger.handlers):
handler = LoggingHandler(logger_provider=logger_provider)
logger_name: str = configurations[LOGGER_NAME_ARG] # type: ignore
logger.addHandler(handler)


Expand Down
12 changes: 6 additions & 6 deletions sdk/monitor/azure-monitor-opentelemetry/samples/logging/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
logger.warning("warning log")
logger.error("error log")

logger.info("info log")
logger.warning("warning log")
logger.error("error log")
logger_child.info("Child: info log")
logger_child.warning("Child: warning log")
logger_child.error("Child: error log")

logger_not_tracked.info("info log2")
logger_not_tracked.warning("warning log2")
logger_not_tracked.error("error log2")
logger_not_tracked.info("Not tracked: info log")
logger_not_tracked.warning("Not tracked: warning log")
logger_not_tracked.error("Not tracked: error log")

input()
Loading