Skip to content

Address comments from SDK review meeting #40748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dargilco merged 16 commits into from
Apr 29, 2025
Merged

Address comments from SDK review meeting #40748

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0199f26
First
dargilco Apr 27, 2025
512386f
Fix mypy
dargilco Apr 28, 2025
ebf4c21
Pylint fixes
dargilco Apr 28, 2025
f8c34b3
Fix dataset samples
dargilco Apr 28, 2025
f5df1ad
Fix borken print in samples
dargilco Apr 28, 2025
e8c1960
pyright fixes/exemptions
dargilco Apr 28, 2025
975361b
Update index and dataset sample names
dargilco Apr 28, 2025
a44fb62
Restore lazy import, since CI pipeline needs azure-ai-agents package
dargilco Apr 28, 2025
df63a0b
More
dargilco Apr 28, 2025
1c4b405
Some pyright fixes
dargilco Apr 28, 2025
8a06303
More fixes
dargilco Apr 28, 2025
624fab0
More quality gate fixes
dargilco Apr 29, 2025
7969001
Merge remote-tracking branch 'origin/feature/azure-ai-projects-beta11…
dargilco Apr 29, 2025
921b5bb
Fix merge
dargilco Apr 29, 2025
908344f
Fix merge conflict
dargilco Apr 29, 2025
1125083
Merge remote-tracking branch 'origin/feature/azure-ai-projects-beta11…
dargilco Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix borken print in samples
  • Loading branch information
@dargilco
dargilco committed Apr 28, 2025
commit f5df1ade96ca6f5d67784836a98db62f3156a4cc
4 changes: 2 additions & 2 deletions sdk/ai/azure-ai-projects/samples/indexes/sample_indexes_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ async def sample_indexes_async() -> None:
)
print(index)

print("Get Index `{index_name}` version `{index_version}`:")
print(f"Get Index `{index_name}` version `{index_version}`:")
index = await project_client.indexes.get(name=index_name, version=index_version)
print(index)

Expand All @@ -66,7 +66,7 @@ async def sample_indexes_async() -> None:
async for index in project_client.indexes.list_versions(name=index_name):
print(index)

print("Delete Index`{index_name}` version `{index_version}`:")
print(f"Delete Index`{index_name}` version `{index_version}`:")
await project_client.indexes.delete(name=index_name, version=index_version)


Expand Down