Skip to content

Address Azure SDK review meeting comment and other fixes / minor changes #40839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dargilco merged 6 commits into from
May 1, 2025
Merged

Address Azure SDK review meeting comment and other fixes / minor changes #40839

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8051bde
Update to 'file_path'
dargilco Apr 30, 2025
19c1be2
Re-emit from latest TypeSpec
dargilco Apr 30, 2025
b1fd86b
Switch to using _get_with_credentials
dargilco Apr 30, 2025
ee070c7
Several changes
dargilco May 1, 2025
7473d69
Merge remote-tracking branch 'origin/feature/azure-ai-projects-beta11…
dargilco May 1, 2025
b42d7e7
Fix quality gates
dargilco May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch to using _get_with_credentials
  • Loading branch information
@dargilco
dargilco committed Apr 30, 2025
commit b1fd86b1b606d82c2b42f7d5f195a910a3db6918
2 changes: 1 addition & 1 deletion sdk/ai/azure-ai-projects/azure/ai/projects/aio/operations/_patch_inference_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ async def get_azure_openai_client(
# If the connection uses API key authentication, we need to make another service call to get
# the connection with API key populated.
if connection.credentials.type == CredentialType.API_KEY:
connection = await self._outer_instance.connections.get_with_credentials(name=connection_name, **kwargs)
connection = await self._outer_instance.connections._get_with_credentials(name=connection_name, **kwargs)

logger.debug("[InferenceOperations.get_azure_openai_client] connection = %s", str(connection))

Expand Down
2 changes: 1 addition & 1 deletion sdk/ai/azure-ai-projects/azure/ai/projects/aio/operations/_patch_telemetry_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ async def get_connection_string(self) -> str:
if not connection_name:
raise ResourceNotFoundError("No Application Insights connection found.")

connection = await self._outer_instance.connections.get_with_credentials(name=connection_name)
connection = await self._outer_instance.connections._get_with_credentials(name=connection_name)

if isinstance(connection.credentials, ApiKeyCredentials):
if not connection.credentials.api_key:
Expand Down
2 changes: 1 addition & 1 deletion sdk/ai/azure-ai-projects/azure/ai/projects/operations/_patch_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def get_azure_openai_client(
# If the connection uses API key authentication, we need to make another service call to get
# the connection with API key populated.
if connection.credentials.type == CredentialType.API_KEY:
connection = self._outer_instance.connections.get_with_credentials(name=connection_name, **kwargs)
connection = self._outer_instance.connections._get_with_credentials(name=connection_name, **kwargs)

logger.debug("[InferenceOperations.get_azure_openai_client] connection = %s", str(connection))

Expand Down
2 changes: 1 addition & 1 deletion sdk/ai/azure-ai-projects/azure/ai/projects/operations/_patch_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def get_connection_string(self) -> str:
if not connection_name:
raise ResourceNotFoundError("No Application Insights connection found.")

connection = self._outer_instance.connections.get_with_credentials(name=connection_name)
connection = self._outer_instance.connections._get_with_credentials(name=connection_name)

if isinstance(connection.credentials, ApiKeyCredentials):
if not connection.credentials.api_key:
Expand Down