Re-emit from TypeSpec, after removing .ServicePatterns from namespace Azure.AI.Projects.ServicePatterns
#41147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
nick863
approved these changes
May 17, 2025
glharper
approved these changes
May 17, 2025
dargilco
merged commit 9ac1655
into
feature/azure-ai-projects/1.0.0b12
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the //build release (beta 11), I had to manually edit auto-generated Python files to remove a client property
.service_patterns, and remove the folder\azure\ai\projects\servicepatternswhich contained empty, unused public classesServicePatternsOptions.I made a TypeSpec change to remove
.ServicePatternsfrom namespaceAzure.AI.Projects.ServicePatterns, and that fixed the problem in the emitted SDK. I also removed the namespaceBuildingBlock. I no longer see that property or folder.This is the TypeSpec PR: Azure/azure-rest-api-specs#34738
In this Python PR, I don't expect to see any changes after re-emitting, since I already manually removed stuff from the auto-generated code. That fact that it did not "come back" after re-emit, means the TypeSpec edits did what I expected it to do. Only minor changes probably related to a new tool version.