Skip to content

Conversation

@iscai-msft
Copy link
Contributor

fixes #41438

Copilot AI review requested due to automatic review settings June 5, 2025 19:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new function, is_sdk_model, to help determine if an object qualifies as an SDK model.

  • Introduces the is_sdk_model function with a clear docstring outlining its purpose
  • Implements a check for either a "_is_model" attribute or "_attribute_map" presence to signal an SDK model
Comments suppressed due to low confidence (1)

sdk/core/azure-core/azure/core/serialization.py:133

  • [nitpick] The docstring for 'is_sdk_model' uses ':type obj: any' which might be clearer if it matches the function's type annotation (i.e., using 'Any' with proper casing) for consistency.
def is_sdk_model(obj: Any) -> bool:

@iscai-msft iscai-msft requested a review from kristapratico June 10, 2025 16:59
@iscai-msft
Copy link
Contributor Author

/check-enforcer override

@iscai-msft iscai-msft merged commit 1d51087 into Azure:main Jun 11, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core] add is_azure_sdk_model duck typing check into azure.core.serialization

4 participants