Skip to content

[DO NOT MERGE] testing graphrbac #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iscai-msft wants to merge 2 commits into from
Closed

[DO NOT MERGE] testing graphrbac #4320

iscai-msft wants to merge 2 commits into from

Conversation

@iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented Feb 6, 2019

No description provided.

@iscai-msft iscai-msft requested a review from lmazuel as a code owner February 6, 2019 22:01
@adxsdk6
Copy link

adxsdk6 commented Feb 6, 2019

Can one of the admins verify this patch?

1 similar comment
@adxsdk6
Copy link

adxsdk6 commented Feb 6, 2019

Can one of the admins verify this patch?

EvgenyAgafonchikov pushed a commit to EvgenyAgafonchikov/azure-sdk-for-python that referenced this pull request Feb 7, 2019
@AutorestCI @lmazuel
[AutoPR] network/resource-manager (Azure#3617)
303d984 
* [AutoPR network/resource-manager] Remove error code from swagger (Azure#3507)

* Generated from 82c4e9010292ed02c88fd64f6d3b7e17bd417eb9

Remove error code from swagger

* Packaging update of azure-mgmt-network

* [AutoPR network/resource-manager] Move parameter to keep order in SDK (Azure#3731)

* Generated from 911ebf46a4a178cdcc6aaa9695f6792f4c64ab89

Move parameter to keep order in SDK

* Packaging update of azure-mgmt-network

* [AutoPR network/resource-manager] Network october release (Azure#3463)

* Generated from bd2aca0

Update ADHybridHealthService.json (Azure#3874)

* Generated from 4b3ae81daaddc6079ec4a6a8ebeebccc019703e6

Updated NetworkConfigurationDiagnostic API + example (Azure#3905)

* Generated from c90c5d14e7b0b169a8cde763860d15aa48a0d37c (Azure#3395)

address the comments

* Generated from 26fc76cf7c2ed2ae5289bd4946513351880d32ff

add customer error spec for Application Gateway (Azure#3985)

* add customer error spec for Application Gateway

* fix property name issue

* [AutoPR network/resource-manager] add customer error spec for Application Gateway (Azure#3409)

* Generated from d9a3af34891cc703ecc3ba298fc737d6cc3e0fc0

add customer error spec for Application Gateway

* Generated from 26299b453a6b2f99683899a78c4c302d39b7de03

fix property name issue

* Generated from 19e41e2e7bb38120b813ad2314dc7c4f422b48c4 (Azure#3417)

Add ICMP to the list of supported protocols

* Generated from ef5d8181e1a9f148a35d1b4467af2427a0afa29d

Merge remote-tracking branch 'origin/master' into network-october-release

* Packaging update of azure-mgmt-network

* Packaging update of azure-mgmt-adhybridhealthservice

* Generated from 7d9b9a991b92bfdbc31be3bf5fd2bd16bbb742a1 (Azure#3478)

change appgw custom error status code enum and fix a typo of customErrorConfiguration

* Generated from 758c143eae019925ae9e021fbcd6821af918d000

Add ExpressRoutePort swagger (Azure#4104)

* Add ExpressRoutePort details to readme.md

* ExpressRoutePort swagger

* Refer SubscriptionIdParameter and ApiVersionParameter from network.json

* Generated from b232daf214b1a03e32b14427be20bbca4ac805ac (Azure#3509)

ExpressRoutePort swagger

* Generated from 6c4312edb758be23c2bdd7f8c2da0b8b76541187

Cherry pick NRP's changes from master to October branch (Azure#4251)

* Remove error code from swagger (Azure#4103)

* Modifying example templates : enabling Ipv6 support for Private Peering (Azure#4232)

* Modifying example templates : enabling Ipv6 support for Private Peering

* Resolving oav validation error

* [AutoPR network/resource-manager] Cherry pick NRP's changes from master to October branch (Azure#3632)

* Generated from 9ef9c433f66560956a610961c0e2a5ec70360064

Modifying example templates : enabling Ipv6 support for Private Peering (Azure#4232)

* Modifying example templates : enabling Ipv6 support for Private Peering

* Resolving oav validation error

* Packaging update of azure-mgmt-network

* Packaging update of azure-mgmt-adhybridhealthservice

* Generated from e8f2b491e5b1732d9e57cdf9ddd16907ba04920e

Changes to add operation id for outbound rules (Azure#4320)

* Changes to add operation id for outbound rules

* Changes to make outbound rule similar to load balancing rule

* fix failures - add example json files

* fix failures

* Fixed line endings, specs, examples

* [AutoPR network/resource-manager] Changes to add operation id for outbound rules (Azure#3687)

* Generated from fb767531a15f75017f43f44004a2aa75c1b13b9f

fix failures

* Generated from a9023fbd65049681b0ccc49d42a1c4276b0cd159

Merge pull request Azure#1 from EvgenyAgafonchikov/fix-lb

Fixed line endings, specs, examples

* [AutoPR network/resource-manager] Change one parameter (Azure#3700)

* Generated from 9392c40ae5bf6575a8fdf47d0609226fdd8da689

Change one parameter

* Generated from 084957762078dc07cce7c40e0d5358081f090e2a

Change parameter in most recent version

* Generated from 1f46c7babbbcc3379f21c6f5e3d16f693fe23111

Fix example

* Generated from d0417082c41cfae8f0234ee02fe32b506bf4e605

New SKU for ER (Azure#4342)

* Packaging update of azure-mgmt-network

* Rebuild by Azure#3617

* Remove azure-mgmt-adhybridhealthservice by mistake on Network service PR

* Network 2.3.0
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #4320 into master will decrease coverage by 0.25%.
The diff coverage is 41.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4320      +/-   ##
==========================================
- Coverage   53.53%   53.28%   -0.26%     
==========================================
  Files       10452    10390      -62     
  Lines      218687   219984    +1297     
==========================================
+ Hits       117066   117210     +144     
- Misses     101621   102774    +1153
Impacted Files Coverage Δ
...c/azure/graphrbac/operations/_oauth2_operations.py 28.57% <ø> (ø)
...hrbac/operations/_service_principals_operations.py 33.92% <0%> (ø)
.../azure/graphrbac/operations/_domains_operations.py 27.11% <0%> (ø)
...hrbac/operations_async/_groups_operations_async.py 10.75% <10.75%> (ø)
...ions_async/_service_principals_operations_async.py 10.83% <10.83%> (ø)
azure-graphrbac/azure/graphrbac/version.py 100% <100%> (ø) ⬆️
...hrbac/azure/graphrbac/operations_async/__init__.py 100% <100%> (ø)
...graphrbac/operations/_signed_in_user_operations.py 91.52% <100%> (ø)
.../azure/graphrbac/operations/_objects_operations.py 88.37% <100%> (ø)
azure-graphrbac/azure/graphrbac/__init__.py 100% <100%> (ø) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59956a...e8c84e6. Read the comment docs.

@lmazuel lmazuel closed this Feb 12, 2019
@iscai-msft iscai-msft deleted the graphrbac_testing branch September 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iscai-msft @adxsdk6 @codecov-io @lmazuel