Skip to content

[AutoPR applicationinsights/resource-manager] [App Insights control plane] fix: validate subId, apiVersion, rgName #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AutorestCI merged 2 commits into from
Mar 29, 2019
Merged

[AutoPR applicationinsights/resource-manager] [App Insights control plane] fix: validate subId, apiVersion, rgName #4720

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a017828
Generated from deddefa89eddea5a43dc26c164d86e1d6a96791d
AutorestCI Mar 29, 2019
1207678
Packaging update of azure-mgmt-applicationinsights
azuresdkci Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Generated from deddefa89eddea5a43dc26c164d86e1d6a96791d 
fix: typo
  • Loading branch information
@AutorestCI
AutorestCI committed Mar 29, 2019
commit a017828b306cea8e8ae349f487ac789f2cbfbb2d
4 changes: 2 additions & 2 deletions ...licationinsights/azure/mgmt/applicationinsights/application_insights_management_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class ApplicationInsightsManagementClientConfiguration(AzureConfiguration):
:param credentials: Credentials needed for the client to connect to Azure.
:type credentials: :mod:`A msrestazure Credentials
object<msrestazure.azure_active_directory>`
:param subscription_id: The Azure subscription ID.
:param subscription_id: The ID of the target subscription.
:type subscription_id: str
:param str base_url: Service URL
"""
Expand Down Expand Up @@ -106,7 +106,7 @@ class ApplicationInsightsManagementClient(SDKClient):
:param credentials: Credentials needed for the client to connect to Azure.
:type credentials: :mod:`A msrestazure Credentials
object<msrestazure.azure_active_directory>`
:param subscription_id: The Azure subscription ID.
:param subscription_id: The ID of the target subscription.
:type subscription_id: str
:param str base_url: Service URL
"""
Expand Down
38 changes: 21 additions & 17 deletions ...plicationinsights/azure/mgmt/applicationinsights/operations/analytics_items_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class AnalyticsItemsOperations(object):
:param config: Configuration of service client.
:param serializer: An object model serializer.
:param deserializer: An object model deserializer.
:ivar api_version: Client Api Version. Constant value: "2015-05-01".
:ivar api_version: The API version to use for this operation. Constant value: "2015-05-01".
"""

models = models
Expand All @@ -42,7 +42,8 @@ def list(
"""Gets a list of Analytics Items defined within an Application Insights
component.

:param resource_group_name: The name of the resource group.
:param resource_group_name: The name of the resource group. The name
is case insensitive.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
Expand Down Expand Up @@ -80,16 +81,16 @@ def list(
# Construct URL
url = self.list.metadata['url']
path_format_arguments = {
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str', max_length=90, min_length=1, pattern=r'^[-\w\._\(\)]+$'),
'resourceName': self._serialize.url("resource_name", resource_name, 'str'),
'scopePath': self._serialize.url("scope_path", scope_path, 'str')
}
url = self._client.format_url(url, **path_format_arguments)

# Construct parameters
query_parameters = {}
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str', min_length=1)
if scope is not None:
query_parameters['scope'] = self._serialize.query("scope", scope, 'str')
if type is not None:
Expand Down Expand Up @@ -133,7 +134,8 @@ def get(
"""Gets a specific Analytics Items defined within an Application Insights
component.

:param resource_group_name: The name of the resource group.
:param resource_group_name: The name of the resource group. The name
is case insensitive.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
Expand Down Expand Up @@ -165,16 +167,16 @@ def get(
# Construct URL
url = self.get.metadata['url']
path_format_arguments = {
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str', max_length=90, min_length=1, pattern=r'^[-\w\._\(\)]+$'),
'resourceName': self._serialize.url("resource_name", resource_name, 'str'),
'scopePath': self._serialize.url("scope_path", scope_path, 'str')
}
url = self._client.format_url(url, **path_format_arguments)

# Construct parameters
query_parameters = {}
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str', min_length=1)
if id is not None:
query_parameters['id'] = self._serialize.query("id", id, 'str')
if name is not None:
Expand Down Expand Up @@ -216,7 +218,8 @@ def put(
"""Adds or Updates a specific Analytics Item within an Application
Insights component.

:param resource_group_name: The name of the resource group.
:param resource_group_name: The name of the resource group. The name
is case insensitive.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
Expand Down Expand Up @@ -249,16 +252,16 @@ def put(
# Construct URL
url = self.put.metadata['url']
path_format_arguments = {
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str', max_length=90, min_length=1, pattern=r'^[-\w\._\(\)]+$'),
'resourceName': self._serialize.url("resource_name", resource_name, 'str'),
'scopePath': self._serialize.url("scope_path", scope_path, 'str')
}
url = self._client.format_url(url, **path_format_arguments)

# Construct parameters
query_parameters = {}
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str', min_length=1)
if override_item is not None:
query_parameters['overrideItem'] = self._serialize.query("override_item", override_item, 'bool')

Expand Down Expand Up @@ -302,7 +305,8 @@ def delete(
"""Deletes a specific Analytics Items defined within an Application
Insights component.

:param resource_group_name: The name of the resource group.
:param resource_group_name: The name of the resource group. The name
is case insensitive.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
Expand Down Expand Up @@ -331,16 +335,16 @@ def delete(
# Construct URL
url = self.delete.metadata['url']
path_format_arguments = {
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str', max_length=90, min_length=1, pattern=r'^[-\w\._\(\)]+$'),
'resourceName': self._serialize.url("resource_name", resource_name, 'str'),
'scopePath': self._serialize.url("scope_path", scope_path, 'str')
}
url = self._client.format_url(url, **path_format_arguments)

# Construct parameters
query_parameters = {}
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str', min_length=1)
if id is not None:
query_parameters['id'] = self._serialize.query("id", id, 'str')
if name is not None:
Expand Down
38 changes: 21 additions & 17 deletions ...t-applicationinsights/azure/mgmt/applicationinsights/operations/annotations_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class AnnotationsOperations(object):
:param config: Configuration of service client.
:param serializer: An object model serializer.
:param deserializer: An object model deserializer.
:ivar api_version: Client Api Version. Constant value: "2015-05-01".
:ivar api_version: The API version to use for this operation. Constant value: "2015-05-01".
"""

models = models
Expand All @@ -41,7 +41,8 @@ def list(
self, resource_group_name, resource_name, start, end, custom_headers=None, raw=False, **operation_config):
"""Gets the list of annotations for a component for given time range.

:param resource_group_name: The name of the resource group.
:param resource_group_name: The name of the resource group. The name
is case insensitive.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
Expand All @@ -68,15 +69,15 @@ def internal_paging(next_link=None, raw=False):
# Construct URL
url = self.list.metadata['url']
path_format_arguments = {
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str', max_length=90, min_length=1, pattern=r'^[-\w\._\(\)]+$'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
'resourceName': self._serialize.url("resource_name", resource_name, 'str')
}
url = self._client.format_url(url, **path_format_arguments)

# Construct parameters
query_parameters = {}
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str', min_length=1)
query_parameters['start'] = self._serialize.query("start", start, 'str')
query_parameters['end'] = self._serialize.query("end", end, 'str')

Expand Down Expand Up @@ -118,7 +119,8 @@ def create(
self, resource_group_name, resource_name, annotation_properties, custom_headers=None, raw=False, **operation_config):
"""Create an Annotation of an Application Insights component.

:param resource_group_name: The name of the resource group.
:param resource_group_name: The name of the resource group. The name
is case insensitive.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
Expand All @@ -141,15 +143,15 @@ def create(
# Construct URL
url = self.create.metadata['url']
path_format_arguments = {
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str', max_length=90, min_length=1, pattern=r'^[-\w\._\(\)]+$'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
'resourceName': self._serialize.url("resource_name", resource_name, 'str')
}
url = self._client.format_url(url, **path_format_arguments)

# Construct parameters
query_parameters = {}
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str', min_length=1)

# Construct headers
header_parameters = {}
Expand Down Expand Up @@ -188,7 +190,8 @@ def delete(
self, resource_group_name, resource_name, annotation_id, custom_headers=None, raw=False, **operation_config):
"""Delete an Annotation of an Application Insights component.

:param resource_group_name: The name of the resource group.
:param resource_group_name: The name of the resource group. The name
is case insensitive.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
Expand All @@ -208,16 +211,16 @@ def delete(
# Construct URL
url = self.delete.metadata['url']
path_format_arguments = {
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str', max_length=90, min_length=1, pattern=r'^[-\w\._\(\)]+$'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
'resourceName': self._serialize.url("resource_name", resource_name, 'str'),
'annotationId': self._serialize.url("annotation_id", annotation_id, 'str')
}
url = self._client.format_url(url, **path_format_arguments)

# Construct parameters
query_parameters = {}
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str', min_length=1)

# Construct headers
header_parameters = {}
Expand Down Expand Up @@ -254,7 +257,8 @@ def get(
self, resource_group_name, resource_name, annotation_id, custom_headers=None, raw=False, **operation_config):
"""Get the annotation for given id.

:param resource_group_name: The name of the resource group.
:param resource_group_name: The name of the resource group. The name
is case insensitive.
:type resource_group_name: str
:param resource_name: The name of the Application Insights component
resource.
Expand All @@ -276,16 +280,16 @@ def get(
# Construct URL
url = self.get.metadata['url']
path_format_arguments = {
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str'),
'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str', max_length=90, min_length=1, pattern=r'^[-\w\._\(\)]+$'),
'subscriptionId': self._serialize.url("self.config.subscription_id", self.config.subscription_id, 'str', min_length=1),
'resourceName': self._serialize.url("resource_name", resource_name, 'str'),
'annotationId': self._serialize.url("annotation_id", annotation_id, 'str')
}
url = self._client.format_url(url, **path_format_arguments)

# Construct parameters
query_parameters = {}
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str')
query_parameters['api-version'] = self._serialize.query("self.api_version", self.api_version, 'str', min_length=1)

# Construct headers
header_parameters = {}
Expand Down
Loading