Skip to content

Add challenge authentication to azure-keyvault-keys #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 8 commits into from
Jul 17, 2019
Merged

Add challenge authentication to azure-keyvault-keys #6244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bb7af5a
sync challenge policy and tests
chlowell Jul 2, 2019
0d4c9e9
async challenge auth policy
chlowell Jul 3, 2019
deca639
prevent redundant challenge in paging
chlowell Jul 5, 2019
ec58a2a
auth challenge policy -> challenge auth policy
chlowell Jul 5, 2019
e29bd85
consolidate challenge code in _shared
chlowell Jul 5, 2019
5352129
test challenge cache ignores https port
chlowell Jul 5, 2019
0223642
_ChallengeAuthPolicyBase -> ChallengeAuthPolicyBase
chlowell Jul 5, 2019
80d3e49
record tests
chlowell Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
_ChallengeAuthPolicyBase -> ChallengeAuthPolicyBase
  • Loading branch information
@chlowell
chlowell committed Jul 9, 2019
commit 02236420c6c9c7177abeb1b470e6f8a25055bd0c
4 changes: 2 additions & 2 deletions sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.
# ------------------------------------
from .challenge_auth_policy import ChallengeAuthPolicy
from .challenge_auth_policy import ChallengeAuthPolicy, ChallengeAuthPolicyBase
from .http_challenge import HttpChallenge
from . import http_challenge_cache as HttpChallengeCache

__all__ = ["ChallengeAuthPolicy", "HttpChallenge", "HttpChallengeCache"]
__all__ = ["ChallengeAuthPolicy", "ChallengeAuthPolicyBase", "HttpChallenge", "HttpChallengeCache"]

try:
from .async_challenge_auth_policy import AsyncChallengeAuthPolicy
Expand Down
5 changes: 2 additions & 3 deletions sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/async_challenge_auth_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@
from azure.core.pipeline.policies import AsyncHTTPPolicy
from azure.core.pipeline.transport import HttpRequest, HttpResponse

from . import HttpChallenge, HttpChallengeCache
from .challenge_auth_policy import _ChallengeAuthPolicyBase
from . import ChallengeAuthPolicyBase, HttpChallenge, HttpChallengeCache


class AsyncChallengeAuthPolicy(_ChallengeAuthPolicyBase, AsyncHTTPPolicy):
class AsyncChallengeAuthPolicy(ChallengeAuthPolicyBase, AsyncHTTPPolicy):
"""policy for handling HTTP authentication challenges"""

async def send(self, request: PipelineRequest) -> HttpResponse:
Expand Down
6 changes: 3 additions & 3 deletions sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/challenge_auth_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
from . import http_challenge_cache as ChallengeCache


class _ChallengeAuthPolicyBase(_BearerTokenCredentialPolicyBase):
class ChallengeAuthPolicyBase(_BearerTokenCredentialPolicyBase):
"""Sans I/O base for challenge authentication policies"""

def __init__(self, credential, **kwargs):
super(_ChallengeAuthPolicyBase, self).__init__(credential, **kwargs)
super(ChallengeAuthPolicyBase, self).__init__(credential, **kwargs)

@staticmethod
def _update_challenge(request, challenger):
Expand All @@ -40,7 +40,7 @@ def _update_challenge(request, challenger):
return challenge


class ChallengeAuthPolicy(_ChallengeAuthPolicyBase, HTTPPolicy):
class ChallengeAuthPolicy(ChallengeAuthPolicyBase, HTTPPolicy):
"""policy for handling HTTP authentication challenges"""

def send(self, request):
Expand Down