Skip to content

create_batch feature implementation #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yunhaoling merged 5 commits into from
Jul 11, 2019
Merged

create_batch feature implementation #6256

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba7d811
Init create batch event
yunhaoling Jul 6, 2019
28ad2f3
create_batch implementation
yunhaoling Jul 9, 2019
3d638fc
Revert _set_partition_key method and update comment
yunhaoling Jul 9, 2019
9779be0
Refacor EventDataBatch class
yunhaoling Jul 10, 2019
d0a51bb
Revert logic when setting partition_key of event_data
yunhaoling Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert logic when setting partition_key of event_data
  • Loading branch information
@yunhaoling
yunhaoling committed Jul 10, 2019
commit d0a51bb9fbdcbbe6394b00390968639e298cfd49
3 changes: 2 additions & 1 deletion sdk/eventhub/azure-eventhubs/azure/eventhub/aio/producer_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,8 @@ async def send(self, event_data, partition_key=None):
"""
self._check_closed()
if isinstance(event_data, EventData):
event_data._set_partition_key(partition_key) # pylint: disable=protected-access
if partition_key:
event_data._set_partition_key(partition_key) # pylint: disable=protected-access
wrapper_event_data = event_data
else:
if isinstance(event_data, EventDataBatch):
Expand Down
3 changes: 2 additions & 1 deletion sdk/eventhub/azure-eventhubs/azure/eventhub/producer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,8 @@ def send(self, event_data, partition_key=None):
"""
self._check_closed()
if isinstance(event_data, EventData):
event_data._set_partition_key(partition_key) # pylint: disable=protected-access
if partition_key:
event_data._set_partition_key(partition_key) # pylint: disable=protected-access
wrapper_event_data = event_data
else:
if isinstance(event_data, EventDataBatch): # The partition_key in the param will be omitted.
Expand Down