Skip to content

Add credential wrapping MSAL ConfidentialClientApplication #6358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 5 commits into from
Jul 17, 2019
Merged

Add credential wrapping MSAL ConfidentialClientApplication #6358

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91b42cc
_internal -> _managed_identity
chlowell Jul 12, 2019
63b4d81
credential wrapping MSAL's ConfidentialClientApplication
chlowell Jul 15, 2019
979769d
extract base class
chlowell Jul 16, 2019
abca102
raise when authentication fails
chlowell Jul 16, 2019
5e27816
compose rather than inherit
chlowell Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
_internal -> _managed_identity
  • Loading branch information
@chlowell
chlowell committed Jul 12, 2019
commit 91b42cc0770df3f93f5a0ea6981db7135a5954f7
0 ...zure-identity/azure/identity/_internal.py → ...ntity/azure/identity/_managed_identity.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...-identity/azure/identity/aio/_internal.py → ...y/azure/identity/aio/_managed_identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

from ._authn_client import AsyncAuthnClient
from ..constants import Endpoints, EnvironmentVariables
from .._internal import _ManagedIdentityBase
from .._managed_identity import _ManagedIdentityBase


class _AsyncManagedIdentityBase(_ManagedIdentityBase):
Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/azure-identity/azure/identity/aio/credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from azure.core.pipeline.policies import ContentDecodePolicy, HeadersPolicy, NetworkTraceLoggingPolicy, AsyncRetryPolicy

from ._authn_client import AsyncAuthnClient
from ._internal import ImdsCredential, MsiCredential
from ._managed_identity import ImdsCredential, MsiCredential
from .._base import ClientSecretCredentialBase, CertificateCredentialBase
from ..constants import Endpoints, EnvironmentVariables
from ..credentials import ChainedTokenCredential
Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/azure-identity/azure/identity/credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

from ._authn_client import AuthnClient
from ._base import ClientSecretCredentialBase, CertificateCredentialBase
from ._internal import ImdsCredential, MsiCredential
from ._managed_identity import ImdsCredential, MsiCredential
from .constants import Endpoints, EnvironmentVariables

try:
Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/azure-identity/tests/test_identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
ManagedIdentityCredential,
ChainedTokenCredential,
)
from azure.identity._internal import ImdsCredential
from azure.identity._managed_identity import ImdsCredential
from azure.identity.constants import EnvironmentVariables

from helpers import mock_response, Request, validating_transport
Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/azure-identity/tests/test_identity_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
EnvironmentCredential,
ManagedIdentityCredential,
)
from azure.identity.aio._internal import ImdsCredential
from azure.identity.aio._managed_identity import ImdsCredential
from azure.identity.constants import EnvironmentVariables

from helpers import mock_response, Request, async_validating_transport
Expand Down